Undo API addition

Author: thurstond

compiler-rt/include/sanitizer/common_interface_defs.h

@@ -485,11 +485,6 @@ void SANITIZER_CDECL __sanitizer_finish_switch_fiber(void *fake_stack_save,
 int SANITIZER_CDECL __sanitizer_get_module_and_offset_for_pc(
     void *pc, char *module_path, size_t module_path_len, void **pc_offset);
 
-// If cloak_sanitizer_signal_handlers() is set, signal/sigaction will pretend
-// that sanitizers did not preinstall any signal handlers. This function clears
-// the cloaking state.
-void SANITIZER_CDECL __sanitizer_uncloak_preinstalled_signal_handlers();
-
 #ifdef __cplusplus
 } // extern "C"
 #endif

compiler-rt/lib/sanitizer_common/sanitizer_common.cpp

@@ -418,12 +418,6 @@ int __sanitizer_install_malloc_and_free_hooks(void (*malloc_hook)(const void *,
   return InstallMallocFreeHooks(malloc_hook, free_hook);
 }
 
-SANITIZER_INTERFACE_ATTRIBUTE
-void __sanitizer_uncloak_preinstalled_signal_handlers() {
-  internal_memset(signal_handler_is_from_sanitizer, 0,
-                  sizeof(signal_handler_is_from_sanitizer));
-}
-
 // Provide default (no-op) implementation of malloc hooks.
 SANITIZER_INTERFACE_WEAK_DEF(void, __sanitizer_malloc_hook, void *ptr,
                              uptr size) {

compiler-rt/lib/sanitizer_common/sanitizer_common_interface.inc

@@ -24,7 +24,6 @@ INTERFACE_WEAK_FUNCTION(__sanitizer_on_print)
 INTERFACE_WEAK_FUNCTION(__sanitizer_report_error_summary)
 INTERFACE_WEAK_FUNCTION(__sanitizer_sandbox_on_notify)
 INTERFACE_WEAK_FUNCTION(__sanitizer_get_dtls_size)
-INTERFACE_FUNCTION(__sanitizer_uncloak_preinstalled_signal_handlers)
 // Sanitizer weak hooks
 INTERFACE_WEAK_FUNCTION(__sanitizer_weak_hook_memcmp)
 INTERFACE_WEAK_FUNCTION(__sanitizer_weak_hook_strcmp)

compiler-rt/test/sanitizer_common/TestCases/Linux/allow_user_segv.cpp

@@ -23,7 +23,10 @@
 // Flaky errors in debuggerd with "waitpid returned unexpected pid (0)" in logcat.
 // UNSUPPORTED: android && i386-target-arch
 
-#include <sanitizer/common_interface_defs.h>
+// Note: this test case is unusual because it retrieves the original
+// (ASan-installed) signal handler; thus, it is incompatible with the
+// cloak_sanitizer_signal_handlers runtime option.
+
 #include <signal.h>
 #include <stdio.h>
 #include <stdlib.h>
@@ -69,10 +72,6 @@ bool InstallHandler(int signum, struct sigaction *original_sigaction) {
 }
 
 int main() {
-  // This test case is unusual because it retrieves the original
-  // (ASan-installed) signal handler; thus, we don't want ASan to cloak them.
-  __sanitizer_uncloak_preinstalled_signal_handlers();
-
   // Let's install handlers for both SIGSEGV and SIGBUS, since pre-Yosemite
   // 32-bit Darwin triggers SIGBUS instead.
   if (InstallHandler(SIGSEGV, &original_sigaction_sigsegv) &&