address comments

Author: michaelrj-google

libc/src/__support/ctype_utils.h

@@ -26,6 +26,17 @@ namespace internal {
 // functions, make sure you have benchmarks to show your new solution is faster,
 // as well as a way to support non-ASCII character encodings.
 
+// Similarly, do not change these functions to use case ranges. e.g.
+//  bool islower(int ch) {
+//    switch(ch) {
+//    case 'a'...'z':
+//      return true;
+//    }
+//  }
+// This assumes the character ranges are contiguous, which they aren't in
+// EBCDIC. Technically we could use some smaller ranges, but that's even harder
+// to read.
+
 LIBC_INLINE static constexpr bool islower(int ch) {
   switch (ch) {
   case 'a':

libc/src/stdio/printf_core/float_hex_converter.h

@@ -137,9 +137,8 @@ LIBC_INLINE int convert_float_hex_exp(Writer *writer,
   for (; mant_cur > 0; --mant_cur, mantissa >>= 4) {
     char mant_mod_16 = static_cast<char>(mantissa % 16);
     char new_digit = static_cast<char>(internal::int_to_b36_char(mant_mod_16));
-    if (internal::isupper(to_conv.conv_name)) {
+    if (internal::isupper(to_conv.conv_name))
       new_digit = static_cast<char>(internal::toupper(new_digit));
-    }
     mant_buffer[mant_cur - 1] = new_digit;
     if (new_digit != '0' && first_non_zero < mant_cur)
       first_non_zero = mant_cur;

libc/test/src/ctype/isalnum_test.cpp

@@ -32,10 +32,9 @@ constexpr char ALNUM_ARRAY[] = {
 };
 
 bool in_span(int ch, LIBC_NAMESPACE::cpp::span<const char> arr) {
-  for (size_t i = 0; i < arr.size(); ++i) {
+  for (size_t i = 0; i < arr.size(); ++i)
     if (static_cast<int>(arr[i]) == ch)
       return true;
-  }
   return false;
 }
 

libc/test/src/ctype/isalpha_test.cpp

@@ -31,10 +31,9 @@ constexpr char ALPHA_ARRAY[] = {
 };
 
 bool in_span(int ch, LIBC_NAMESPACE::cpp::span<const char> arr) {
-  for (size_t i = 0; i < arr.size(); ++i) {
+  for (size_t i = 0; i < arr.size(); ++i)
     if (static_cast<int>(arr[i]) == ch)
       return true;
-  }
   return false;
 }
 

libc/test/src/ctype/isdigit_test.cpp

@@ -28,10 +28,9 @@ constexpr char DIGIT_ARRAY[] = {
 };
 
 bool in_span(int ch, LIBC_NAMESPACE::cpp::span<const char> arr) {
-  for (size_t i = 0; i < arr.size(); ++i) {
+  for (size_t i = 0; i < arr.size(); ++i)
     if (static_cast<int>(arr[i]) == ch)
       return true;
-  }
   return false;
 }
 

libc/test/src/ctype/islower_test.cpp

@@ -29,10 +29,9 @@ constexpr char LOWER_ARRAY[] = {
 };
 
 bool in_span(int ch, LIBC_NAMESPACE::cpp::span<const char> arr) {
-  for (size_t i = 0; i < arr.size(); ++i) {
+  for (size_t i = 0; i < arr.size(); ++i)
     if (static_cast<int>(arr[i]) == ch)
       return true;
-  }
   return false;
 }
 

libc/test/src/ctype/isupper_test.cpp

@@ -29,10 +29,9 @@ constexpr char UPPER_ARRAY[] = {
 };
 
 bool in_span(int ch, LIBC_NAMESPACE::cpp::span<const char> arr) {
-  for (size_t i = 0; i < arr.size(); ++i) {
+  for (size_t i = 0; i < arr.size(); ++i)
     if (static_cast<int>(arr[i]) == ch)
       return true;
-  }
   return false;
 }
 

libc/test/src/ctype/isxdigit_test.cpp

@@ -30,10 +30,9 @@ constexpr char XDIGIT_ARRAY[] = {
 };
 
 bool in_span(int ch, LIBC_NAMESPACE::cpp::span<const char> arr) {
-  for (size_t i = 0; i < arr.size(); ++i) {
+  for (size_t i = 0; i < arr.size(); ++i)
     if (static_cast<int>(arr[i]) == ch)
       return true;
-  }
   return false;
 }
 

libc/test/src/ctype/tolower_test.cpp

@@ -39,10 +39,9 @@ static_assert(
     "There must be the same number of uppercase and lowercase letters.");
 
 int span_index(int ch, LIBC_NAMESPACE::cpp::span<const char> arr) {
-  for (size_t i = 0; i < arr.size(); ++i) {
+  for (size_t i = 0; i < arr.size(); ++i)
     if (static_cast<int>(arr[i]) == ch)
       return static_cast<int>(i);
-  }
   return -1;
 }
 

libc/test/src/ctype/toupper_test.cpp

@@ -39,10 +39,9 @@ static_assert(
     "There must be the same number of uppercase and lowercase letters.");
 
 int span_index(int ch, LIBC_NAMESPACE::cpp::span<const char> arr) {
-  for (size_t i = 0; i < arr.size(); ++i) {
+  for (size_t i = 0; i < arr.size(); ++i)
     if (static_cast<int>(arr[i]) == ch)
       return static_cast<int>(i);
-  }
   return -1;
 }