amend! [C-API] LLVMOrcCreateObjectLinkingLayerWithInProcessMemoryManager

[C-API] LLVMOrcCreateObjectLinkingLayerWithInProcessMemoryManager (#169862)

Allow C programs to use JITLink instead of RuntimeDyld.  Modeled on
LLVMOrcCreateRTDyldObjectLinkingLayerWithSectionMemoryManager except
that it has to deal with failure to create InProcessMemoryManager.

Author: macdice

llvm/include/llvm-c/OrcEE.h

@@ -45,12 +45,11 @@ typedef void (*LLVMMemoryManagerNotifyTerminatingCallback)(void *CtxCtx);
 
 /**
  * Create a ObjectLinkingLayer instance using the standard JITLink
- * InProcessMemoryManager for memory management.  Result is NULL on failure to
- * determine system page size.
+ * InProcessMemoryManager for memory management.
  */
-LLVMOrcObjectLayerRef
+LLVM_C_ABI LLVMErrorRef
 LLVMOrcCreateObjectLinkingLayerWithInProcessMemoryManager(
-    LLVMOrcExecutionSessionRef ES);
+    LLVMOrcObjectLayerRef *Result, LLVMOrcExecutionSessionRef ES);
 
 /**
  * Create a RTDyldObjectLinkingLayer instance using the standard

llvm/lib/ExecutionEngine/Orc/OrcV2CBindings.cpp

@@ -1019,16 +1019,16 @@ LLVMOrcLLJITGetObjTransformLayer(LLVMOrcLLJITRef J) {
   return wrap(&unwrap(J)->getObjTransformLayer());
 }
 
-LLVMOrcObjectLayerRef
-LLVMOrcCreateObjectLinkingLayerWithInProcessMemoryManager(
-    LLVMOrcExecutionSessionRef ES) {
+LLVMErrorRef LLVMOrcCreateObjectLinkingLayerWithInProcessMemoryManager(
+    LLVMOrcObjectLayerRef *Result, LLVMOrcExecutionSessionRef ES) {
+  assert(Result && "Result must not be null");
   assert(ES && "ES must not be null");
-  auto mm = jitlink::InProcessMemoryManager::Create();
-  if (!mm) {
-    unwrap(ES)->reportError(mm.takeError());
-    return nullptr;
+  auto MM = jitlink::InProcessMemoryManager::Create();
+  if (!MM) {
+    return wrap(MM.takeError());
   }
-  return wrap(new ObjectLinkingLayer(*unwrap(ES), std::move(*mm)));
+  *Result = wrap(new ObjectLinkingLayer(*unwrap(ES), std::move(*MM)));
+  return LLVMErrorSuccess;
 }
 
 LLVMOrcObjectLayerRef