Remove LLVMSupport through properties of ClangReplInterpreterTests instead of AddLLVM.cmake modification

Author: mcbarton

clang/unittests/Interpreter/CMakeLists.txt

@@ -49,6 +49,11 @@ add_distinct_clang_unittest(ClangReplInterpreterTests
   )
 
 if(EMSCRIPTEN)
+# Without the above you try to link to LLVMSupport twice, and end
+# up with a duplicate symbol error when creating the main module
+get_target_property(LINKED_LIBS ClangReplInterpreterTests LINK_LIBRARIES)
+list(REMOVE_ITEM LINKED_LIBS LLVMSupport)
+set_target_properties(ClangReplInterpreterTests PROPERTIES LINK_LIBRARIES "${LINKED_LIBS}")
 target_link_options(ClangReplInterpreterTests
   PUBLIC "SHELL: -s MAIN_MODULE=1"
   PUBLIC "SHELL: -s ALLOW_MEMORY_GROWTH=1"

llvm/cmake/modules/AddLLVM.cmake

@@ -1764,9 +1764,7 @@ function(add_unittest test_suite test_name)
     set(LLVM_REQUIRES_RTTI OFF)
   endif()
 
-  if(NOT EMSCRIPTEN)
-    list(APPEND LLVM_LINK_COMPONENTS Support) # gtest needs it for raw_ostream
-  endif()
+  list(APPEND LLVM_LINK_COMPONENTS Support) # gtest needs it for raw_ostream
   add_llvm_executable(${test_name} IGNORE_EXTERNALIZE_DEBUGINFO NO_INSTALL_RPATH ${ARGN})
   get_subproject_title(subproject_title)
   set_target_properties(${test_name} PROPERTIES FOLDER "${subproject_title}/Tests/Unit")