Skip to content

Commit 8e7d477

Browse files
committed
Review nits
1 parent cc10e10 commit 8e7d477

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -454,14 +454,14 @@ static void wmmaPushInputOperand(ConversionPatternRewriter &rewriter,
454454
? (Type)rewriter.getIntegerType(numBits)
455455
: (Type)VectorType::get(numBits / 32, i32);
456456
auto llvmIntrinsicInType = typeConverter->convertType(intrinsicInType);
457-
Value result = rewriter.createOrFold<LLVM::BitcastOp>(
457+
Value castInput = rewriter.createOrFold<LLVM::BitcastOp>(
458458
loc, llvmIntrinsicInType, llvmInput);
459459
// The wave64-mode 16x16x16 intrinsics that take 4-bit integers only need
460460
// (256 / 64) * 4 = 16 bits of input (on gfx12+) but take i32 arguments.
461461
// Add in the zeros here.
462462
if (numBits < 32)
463-
result = rewriter.create<LLVM::ZExtOp>(loc, i32, result);
464-
operands.push_back(result);
463+
castInput = rewriter.create<LLVM::ZExtOp>(loc, i32, castInput);
464+
operands.push_back(castInput);
465465
}
466466

467467
/// Push the output operand. For many cases this is only pushing the output in

0 commit comments

Comments
 (0)