[clang-tidy] Use StringRef::consume_back (NFC) (#139412)

kazutakahirata · web-flow · commit 8e9da213ea40 · 2025-05-10T16:05:45.000-07:00
diff --git a/clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp b/clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp
@@ -19,9 +19,8 @@ namespace {
 
 StringRef removeFirstSuffix(StringRef Str, ArrayRef<const char *> Suffixes) {
   for (StringRef Suffix : Suffixes) {
-    if (Str.ends_with(Suffix)) {
-      return Str.substr(0, Str.size() - Suffix.size());
-    }
+    if (Str.consume_back(Suffix))
+      return Str;
   }
   return Str;
 }

Original file line number	Diff line number	Diff line change
`@@ -19,9 +19,8 @@ namespace {`
`19`	`19`
`20`	`20`	`StringRef removeFirstSuffix(StringRef Str, ArrayRef<const char *> Suffixes) {`
`21`	`21`	`for (StringRef Suffix : Suffixes) {`
`22`		`- if (Str.ends_with(Suffix)) {`
`23`		`- return Str.substr(0, Str.size() - Suffix.size());`
`24`		`- }`
	`22`	`+ if (Str.consume_back(Suffix))`
	`23`	`+ return Str;`
`25`	`24`	`}`
`26`	`25`	`return Str;`
`27`	`26`	`}`