Skip to content

Commit 8ef6661

Browse files
committed
fixup! [mlir][linalg] Add support for scalable vectorization of linalg.mmt4d
Revert changes in comments
1 parent 487db47 commit 8ef6661

File tree

1 file changed

+12
-13
lines changed

1 file changed

+12
-13
lines changed

mlir/lib/Dialect/Linalg/Transforms/Vectorization.cpp

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -225,8 +225,7 @@ struct VectorizationState {
225225
ArrayRef<bool> inputScalableVecDims,
226226
bool assumeScalableVecSizesMatchDimSize = false);
227227

228-
/// Returns the canonical vector shape used to vectorize the iteration
229-
/// space.
228+
/// Returns the canonical vector shape used to vectorize the iteration space.
230229
ArrayRef<int64_t> getCanonicalVecShape() const { return canonicalVecShape; }
231230

232231
/// Returns the vector dimensions that are scalable in the canonical vector
@@ -235,8 +234,8 @@ struct VectorizationState {
235234

236235
/// Returns a vector type of the provided `elementType` with the canonical
237236
/// vector shape and the corresponding fixed/scalable dimensions bit. If
238-
/// `dimPermutation` is provided, the canonical vector dimensions are
239-
/// permuted accordingly.
237+
/// `dimPermutation` is provided, the canonical vector dimensions are permuted
238+
/// accordingly.
240239
VectorType getCanonicalVecType(
241240
Type elementType,
242241
std::optional<AffineMap> dimPermutation = std::nullopt) const {
@@ -256,9 +255,9 @@ struct VectorizationState {
256255
}
257256

258257
/// Masks an operation with the canonical vector mask if the operation needs
259-
/// masking. Returns the masked operation or the original operation if
260-
/// masking is not needed. If provided, the canonical mask for this
261-
/// operation is permuted using `maybeIndexingMap`.
258+
/// masking. Returns the masked operation or the original operation if masking
259+
/// is not needed. If provided, the canonical mask for this operation is
260+
/// permuted using `maybeIndexingMap`.
262261
Operation *
263262
maskOperation(RewriterBase &rewriter, Operation *opToMask, LinalgOp linalgOp,
264263
std::optional<AffineMap> maybeIndexingMap = std::nullopt);
@@ -278,15 +277,15 @@ struct VectorizationState {
278277

279278
/// Create or retrieve an existing mask value to mask `opToMask` in the
280279
/// canonical vector iteration space. If `maybeMaskingMap` the mask is
281-
/// permuted using that permutation map. If a new mask is created, it will
282-
/// be cached for future users.
280+
/// permuted using that permutation map. If a new mask is created, it will be
281+
/// cached for future users.
283282
Value getOrCreateMaskFor(RewriterBase &rewriter, Operation *opToMask,
284283
LinalgOp linalgOp,
285284
std::optional<AffineMap> maybeMaskingMap);
286285

287286
/// Check whether this permutation map can be used for masking. At the
288-
/// moment we only make sure that there are no broadcast dimensions, but
289-
/// this might change if indexing maps evolve.
287+
/// moment we only make sure that there are no broadcast dimensions, but this
288+
/// might change if indexing maps evolve.
290289
bool isValidMaskingMap(AffineMap maskingMap) {
291290
return maskingMap.getBroadcastDims().size() == 0;
292291
}
@@ -326,8 +325,8 @@ struct VectorizationState {
326325
/// shape.
327326
SmallVector<bool> scalableVecDims;
328327

329-
/// Holds the active masks for permutations of the canonical vector
330-
/// iteration space.
328+
/// Holds the active masks for permutations of the canonical vector iteration
329+
/// space.
331330
DenseMap<AffineMap, Value> activeMaskCache;
332331

333332
/// Global vectorization guard for the incoming rewriter. It's initialized

0 commit comments

Comments
 (0)