[FIX] while iterating over declaration users make sure we increment iterator

PankajDwivedi-25 · PankajDwivedi-25 · commit 8f5521cd04f5 · 2025-10-09T11:56:23.000+05:30
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUUniformIntrinsicCombine.cpp b/llvm/lib/Target/AMDGPU/AMDGPUUniformIntrinsicCombine.cpp
@@ -138,7 +138,7 @@ static bool runUniformIntrinsicCombine(Module &M, ModuleAnalysisManager &AM) {
       continue;
     }
 
-    for (User *U : F.users()) {
+    for (User *U : make_early_inc_range(F.users())) {
       auto *II = cast<IntrinsicInst>(U);
       Function *ParentF = II->getFunction();
       const auto &UI = FAM.getResult<UniformityInfoAnalysis>(*ParentF);

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ static bool runUniformIntrinsicCombine(Module &M, ModuleAnalysisManager &AM) {`
`138`	`138`	`continue;`
`139`	`139`	`}`
`140`	`140`
`141`		`- for (User *U : F.users()) {`
	`141`	`+ for (User *U : make_early_inc_range(F.users())) {`
`142`	`142`	`auto *II = cast<IntrinsicInst>(U);`
`143`	`143`	`Function *ParentF = II->getFunction();`
`144`	`144`	`const auto &UI = FAM.getResult<UniformityInfoAnalysis>(*ParentF);`