Skip to content

Commit 8f6a513

Browse files
committed
[AMDGPU] Renamed atomic no return baseopcode
1 parent 7905830 commit 8f6a513

File tree

4 files changed

+10
-9
lines changed

4 files changed

+10
-9
lines changed

llvm/lib/Target/AMDGPU/AMDGPUInstrInfo.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ const D16ImageDimIntrinsic *lookupD16ImageDimIntrinsic(unsigned Intr);
5050
struct ImageDimIntrinsicInfo {
5151
unsigned Intr;
5252
unsigned BaseOpcode;
53-
unsigned NoRetBaseOpcode;
53+
unsigned AtomicNoRetBaseOpcode;
5454
MIMGDim Dim;
5555

5656
uint8_t NumOffsetArgs;

llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2009,10 +2009,10 @@ bool AMDGPUInstructionSelector::selectImageIntrinsic(
20092009
unsigned IntrOpcode = Intr->BaseOpcode;
20102010

20112011
// For image atomic: use no-return opcode if result is unused.
2012-
if (Intr->NoRetBaseOpcode != Intr->BaseOpcode) {
2012+
if (Intr->AtomicNoRetBaseOpcode != Intr->BaseOpcode) {
20132013
Register ResultDef = MI.getOperand(0).getReg();
20142014
if (MRI->use_nodbg_empty(ResultDef))
2015-
IntrOpcode = Intr->NoRetBaseOpcode;
2015+
IntrOpcode = Intr->AtomicNoRetBaseOpcode;
20162016
}
20172017

20182018
const AMDGPU::MIMGBaseOpcodeInfo *BaseOpcode =

llvm/lib/Target/AMDGPU/MIMGInstructions.td

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1823,7 +1823,7 @@ let SubtargetPredicate = isGFX12Plus in {
18231823
class ImageDimIntrinsicInfo<AMDGPUImageDimIntrinsic I> {
18241824
Intrinsic Intr = I;
18251825
MIMGBaseOpcode BaseOpcode = !cast<MIMGBaseOpcode>(!strconcat("IMAGE_", I.P.OpMod));
1826-
MIMGBaseOpcode NoRetBaseOpcode = BaseOpcode;
1826+
MIMGBaseOpcode AtomicNoRetBaseOpcode = BaseOpcode;
18271827
AMDGPUDimProps Dim = I.P.Dim;
18281828
AMDGPUImageDimIntrinsicEval DimEval = AMDGPUImageDimIntrinsicEval<I.P>;
18291829

@@ -1861,18 +1861,18 @@ class ImageDimIntrinsicInfo<AMDGPUImageDimIntrinsic I> {
18611861

18621862
class ImageDimAtomicIntrinsicInfo<AMDGPUImageDimIntrinsic I>
18631863
: ImageDimIntrinsicInfo<I> {
1864-
MIMGBaseOpcode NoRetBaseOpcode =
1864+
MIMGBaseOpcode AtomicNoRetBaseOpcode =
18651865
!cast<MIMGBaseOpcode>(!strconcat("IMAGE_", I.P.OpMod, "_NORTN"));
18661866
}
18671867

18681868
def ImageDimIntrinsicTable : GenericTable {
18691869
let FilterClass = "ImageDimIntrinsicInfo";
1870-
let Fields = ["Intr", "BaseOpcode", "NoRetBaseOpcode", "Dim", "NumOffsetArgs", "NumBiasArgs", "NumZCompareArgs", "NumGradients", "NumDmask", "NumData",
1870+
let Fields = ["Intr", "BaseOpcode", "AtomicNoRetBaseOpcode", "Dim", "NumOffsetArgs", "NumBiasArgs", "NumZCompareArgs", "NumGradients", "NumDmask", "NumData",
18711871
"NumVAddrs", "NumArgs", "DMaskIndex", "VAddrStart", "OffsetIndex", "BiasIndex", "ZCompareIndex", "GradientStart", "CoordStart", "LodIndex", "MipIndex",
18721872
"VAddrEnd", "RsrcIndex", "SampIndex", "UnormIndex", "TexFailCtrlIndex", "CachePolicyIndex",
18731873
"BiasTyArg", "GradientTyArg", "CoordTyArg"];
18741874
string TypeOf_BaseOpcode = "MIMGBaseOpcode";
1875-
string TypeOf_NoRetBaseOpcode = "MIMGBaseOpcode";
1875+
string TypeOf_AtomicNoRetBaseOpcode = "MIMGBaseOpcode";
18761876
string TypeOf_Dim = "MIMGDim";
18771877

18781878
let PrimaryKey = ["Intr"];

llvm/lib/Target/AMDGPU/SIISelLowering.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9150,9 +9150,10 @@ SDValue SITargetLowering::lowerImage(SDValue Op,
91509150
MachineFunction &MF = DAG.getMachineFunction();
91519151
const GCNSubtarget *ST = &MF.getSubtarget<GCNSubtarget>();
91529152
unsigned IntrOpcode = Intr->BaseOpcode;
9153-
if (Intr->NoRetBaseOpcode != Intr->BaseOpcode &&
9153+
// For image atomic: use no-return opcode if result is unused.
9154+
if (Intr->AtomicNoRetBaseOpcode != Intr->BaseOpcode &&
91549155
!Op.getNode()->hasAnyUseOfValue(0))
9155-
IntrOpcode = Intr->NoRetBaseOpcode;
9156+
IntrOpcode = Intr->AtomicNoRetBaseOpcode;
91569157
const AMDGPU::MIMGBaseOpcodeInfo *BaseOpcode =
91579158
AMDGPU::getMIMGBaseOpcodeInfo(IntrOpcode);
91589159
const AMDGPU::MIMGDimInfo *DimInfo = AMDGPU::getMIMGDimInfo(Intr->Dim);

0 commit comments

Comments
 (0)