Skip to content

Commit 900c796

Browse files
committed
adding more tests
1 parent c8f7e13 commit 900c796

File tree

2 files changed

+18
-10
lines changed

2 files changed

+18
-10
lines changed

clang/test/SemaHLSL/RootSignature-err.hlsl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,10 @@ void basic_validation_5() {}
191191
[RootSignature("StaticSampler(s0, mipLODBias = 15.990001)")]
192192
void basic_validation_6() {}
193193

194+
// expected-error@+1 {{invalid value of flags}}
195+
[RootSignature("StaticSampler(s0, flags = FLAG_TYPO)")]
196+
void basic_validation_7() {}
197+
194198
// expected-error@+1 {{sampler and non-sampler resource mixed in descriptor table}}
195199
[RootSignature("DescriptorTable(Sampler(s0), CBV(b0))")]
196200
void mixed_resource_table() {}

clang/test/SemaHLSL/RootSignature-flags-err.hlsl

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
// RUN: -fdx-rootsignature-version=rootsig_1_0 %s -verify=v10
33
// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -fsyntax-only \
44
// RUN: -fdx-rootsignature-version=rootsig_1_1 %s -verify=v11
5-
5+
// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -fsyntax-only \
6+
// RUN: -fdx-rootsignature-version=rootsig_1_2 %s -verify=v12
67
// Root Descriptor Flags:
78

89
// v10-error@+1 {{invalid flags for version 1.0}}
@@ -13,8 +14,9 @@ void bad_root_descriptor_flags_0() {}
1314
[RootSignature("CBV(b0, flags = DATA_STATIC_WHILE_SET_AT_EXECUTE)")]
1415
void bad_root_descriptor_flags_1() {}
1516

16-
// v10-error@+2 {{invalid flags for version 1.0}}
17-
// v11-error@+1 {{invalid flags for version 1.1}}
17+
// v10-error@+3 {{invalid flags for version 1.0}}
18+
// v11-error@+2 {{invalid flags for version 1.1}}
19+
// v12-error@+1 {{invalid flags for version 1.2}}
1820
[RootSignature("CBV(b0, flags = DATA_STATIC | DATA_VOLATILE)")]
1921
void bad_root_descriptor_flags_2() {}
2022

@@ -40,18 +42,20 @@ void bad_descriptor_range_flags_3() {}
4042
[RootSignature("DescriptorTable(CBV(b0, flags = DESCRIPTORS_STATIC_KEEPING_BUFFER_BOUNDS_CHECKS))")]
4143
void bad_descriptor_range_flags_4() {}
4244

43-
// v10-error@+2 {{invalid flags for version 1.0}}
44-
// v11-error@+1 {{invalid flags for version 1.1}}
45+
// v10-error@+3 {{invalid flags for version 1.0}}
46+
// v11-error@+2 {{invalid flags for version 1.1}}
47+
// v12-error@+1 {{invalid flags for version 1.2}}
4548
[RootSignature("DescriptorTable(CBV(b0, flags = DATA_STATIC | DATA_STATIC_WHILE_SET_AT_EXECUTE))")]
4649
void bad_descriptor_range_flags_5() {}
4750

48-
// v10-error@+2 {{invalid flags for version 1.0}}
49-
// v11-error@+1 {{invalid flags for version 1.1}}
51+
// v10-error@+3 {{invalid flags for version 1.0}}
52+
// v11-error@+2 {{invalid flags for version 1.1}}
53+
// v12-error@+1 {{invalid flags for version 1.2}}
5054
[RootSignature("DescriptorTable(CBV(b0, flags = DESCRIPTORS_VOLATILE | DESCRIPTORS_STATIC_KEEPING_BUFFER_BOUNDS_CHECKS))")]
5155
void bad_descriptor_range_flags_6() {}
5256

53-
// v10-error@+2 {{invalid flags for version 1.0}}
54-
// v11-error@+1 {{invalid flags for version 1.1}}
57+
// v10-error@+3 {{invalid flags for version 1.0}}
58+
// v11-error@+2 {{invalid flags for version 1.1}}
59+
// v12-error@+1 {{invalid flags for version 1.2}}
5560
[RootSignature("DescriptorTable(CBV(b0, flags = DESCRIPTORS_VOLATILE | DATA_STATIC))")]
5661
void bad_descriptor_range_flags_7() {}
57-

0 commit comments

Comments
 (0)