Clean docs and renamed enqueueHostCallback

Author: RossBrunton

offload/liboffload/src/OffloadImpl.cpp

@@ -836,8 +836,8 @@ Error olGetSymbolInfoSize_impl(ol_symbol_handle_t Symbol,
 Error olLaunchHostFunction_impl(ol_queue_handle_t Queue,
                                 ol_host_function_cb_t Callback,
                                 void *UserData) {
-  return Queue->Device->Device->enqueueHostCallback(Callback, UserData,
-                                                    Queue->AsyncInfo);
+  return Queue->Device->Device->enqueueHostCall(Callback, UserData,
+                                                Queue->AsyncInfo);
 }
 
 } // namespace offload

offload/plugins-nextgen/amdgpu/src/rtl.cpp

@@ -2592,8 +2592,8 @@ struct AMDGPUDeviceTy : public GenericDeviceTy, AMDGenericDeviceTy {
     return Plugin::success();
   }
 
-  Error enqueueHostCallbackImpl(void (*Callback)(void *), void *UserData,
-                                AsyncInfoWrapperTy &AsyncInfo) override {
+  Error enqueueHostCallImpl(void (*Callback)(void *), void *UserData,
+                            AsyncInfoWrapperTy &AsyncInfo) override {
     AMDGPUStreamTy *Stream = nullptr;
     if (auto Err = getStream(AsyncInfo, Stream))
       return Err;

offload/plugins-nextgen/common/include/PluginInterface.h

@@ -965,12 +965,11 @@ struct GenericDeviceTy : public DeviceAllocatorTy {
   Error initDeviceInfo(__tgt_device_info *DeviceInfo);
   virtual Error initDeviceInfoImpl(__tgt_device_info *DeviceInfo) = 0;
 
-  /// Enqueue a host call to  AsyncInfo
-  Error enqueueHostCallback(void (*Callback)(void *), void *UserData,
-                            __tgt_async_info *AsyncInfo);
-  virtual Error enqueueHostCallbackImpl(void (*Callback)(void *),
-                                        void *UserData,
-                                        AsyncInfoWrapperTy &AsyncInfo) = 0;
+  /// Enqueue a host call to AsyncInfo
+  Error enqueueHostCall(void (*Callback)(void *), void *UserData,
+                        __tgt_async_info *AsyncInfo);
+  virtual Error enqueueHostCallImpl(void (*Callback)(void *), void *UserData,
+                                    AsyncInfoWrapperTy &AsyncInfo) = 0;
 
   /// Create an event.
   Error createEvent(void **EventPtrStorage);

offload/plugins-nextgen/common/src/PluginInterface.cpp

@@ -1589,12 +1589,11 @@ Error GenericDeviceTy::initAsyncInfo(__tgt_async_info **AsyncInfoPtr) {
   return Err;
 }
 
-Error GenericDeviceTy::enqueueHostCallback(void (*Callback)(void *),
-                                           void *UserData,
-                                           __tgt_async_info *AsyncInfo) {
+Error GenericDeviceTy::enqueueHostCall(void (*Callback)(void *), void *UserData,
+                                       __tgt_async_info *AsyncInfo) {
   AsyncInfoWrapperTy AsyncInfoWrapper(*this, AsyncInfo);
 
-  auto Err = enqueueHostCallbackImpl(Callback, UserData, AsyncInfoWrapper);
+  auto Err = enqueueHostCallImpl(Callback, UserData, AsyncInfoWrapper);
   AsyncInfoWrapper.finalize(Err);
   return Err;
 }

offload/plugins-nextgen/cuda/src/rtl.cpp

@@ -873,8 +873,8 @@ struct CUDADeviceTy : public GenericDeviceTy {
     return Plugin::success();
   }
 
-  Error enqueueHostCallbackImpl(void (*Callback)(void *), void *UserData,
-                                AsyncInfoWrapperTy &AsyncInfo) override {
+  Error enqueueHostCallImpl(void (*Callback)(void *), void *UserData,
+                            AsyncInfoWrapperTy &AsyncInfo) override {
     if (auto Err = setContext())
       return Err;
 

offload/plugins-nextgen/host/src/rtl.cpp

@@ -320,8 +320,8 @@ struct GenELF64DeviceTy : public GenericDeviceTy {
                          "initDeviceInfoImpl not supported");
   }
 
-  Error enqueueHostCallbackImpl(void (*Callback)(void *), void *UserData,
-                                AsyncInfoWrapperTy &AsyncInfo) override {
+  Error enqueueHostCallImpl(void (*Callback)(void *), void *UserData,
+                            AsyncInfoWrapperTy &AsyncInfo) override {
     Callback(UserData);
     return Plugin::success();
   };