fix review

Author: HerrCai0907

clang-tools-extra/clang-tidy/bugprone/UnintendedCharOstreamOutputCheck.cpp

@@ -60,9 +60,9 @@ void UnintendedCharOstreamOutputCheck::check(
   const auto *Call = Result.Nodes.getNodeAs<CXXOperatorCallExpr>("x");
   const Expr *Value = Call->getArg(1);
   diag(Call->getOperatorLoc(),
-       "(%0 passed to 'operator<<' outputs as character instead of integer. "
+       "%0 passed to 'operator<<' outputs as character instead of integer. "
        "cast to 'unsigned' to print numeric value or cast to 'char' to print "
-       "as character)")
+       "as character")
       << Value->getType() << Value->getSourceRange();
 }
 

clang-tools-extra/docs/clang-tidy/checks/bugprone/unintended-char-ostream-output.rst

@@ -21,10 +21,10 @@ It could be fixed as
 
 .. code-block:: c++
 
-    std::cout << (uint32_t)v;
+    std::cout << static_cast<uint32_t>(v);
 
 Or cast to char to explicitly indicate the intent
 
 .. code-block:: c++
 
-    std::cout << (char)v;
+    std::cout << static_cast<char>(v);

clang-tools-extra/test/clang-tidy/checkers/bugprone/unintended-char-ostream-output.cpp

@@ -30,12 +30,12 @@ class A : public std::ostream {};
 void origin_ostream(std::ostream &os) {
   unsigned char unsigned_value = 9;
   os << unsigned_value;
-  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: ('unsigned char' passed to
+  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: 'unsigned char' passed to
   // 'operator<<' outputs as character instead of integer
 
   signed char signed_value = 9;
   os << signed_value;
-  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: ('signed char' passed to
+  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: 'signed char' passed to
   // 'operator<<' outputs as character instead of integer
 
   char char_value = 9;
@@ -45,12 +45,12 @@ void origin_ostream(std::ostream &os) {
 void based_on_ostream(A &os) {
   unsigned char unsigned_value = 9;
   os << unsigned_value;
-  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: ('unsigned char' passed to
+  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: 'unsigned char' passed to
   // 'operator<<' outputs as character instead of integer
 
   signed char signed_value = 9;
   os << signed_value;
-  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: ('signed char' passed to
+  // CHECK-MESSAGES: [[@LINE-1]]:6: warning: 'signed char' passed to
   // 'operator<<' outputs as character instead of integer
 
   char char_value = 9;