respond to review comments§

Author: Stylie777

flang/lib/Evaluate/tools.cpp

@@ -1217,12 +1217,6 @@ struct HasStructureComponentHelper
   HasStructureComponentHelper() : Base(*this) {}
   using Base::operator();
 
-  bool operator()(const DataRef &dataRef) const {
-    return std::holds_alternative<Component>(dataRef.u);
-  }
-  bool operator()(const NamedEntity &NamedEntity) const {
-    return NamedEntity.UnwrapComponent() != nullptr;
-  }
   bool operator()(const Component &) const { return true; }
 };
 

flang/lib/Semantics/check-omp-structure.cpp

@@ -4676,7 +4676,7 @@ void OmpStructureChecker::CheckStructureComponent(
     if (const parser::DataRef *dataRef{
             std::get_if<parser::DataRef>(&designator.u)}) {
       if (!IsDataRefTypeParamInquiry(dataRef)) {
-        const auto expr = AnalyzeExpr(context_, designator);
+        const auto expr {AnalyzeExpr(context_, designator)};
         if (expr.has_value() && evaluate::HasStructureComponent(expr.value())) {
           context_.Say(designator.source,
               "A variable that is part of another variable cannot appear on the %s clause"_err_en_US,