use structured bindings and simplify dyn_cast

Author: bcardosolopes

mlir/lib/Target/LLVMIR/ModuleImport.cpp

@@ -1080,7 +1080,7 @@ ModuleImport::convertGlobalCtorsAndDtors(llvm::GlobalVariable *globalVar) {
 
   SmallVector<Attribute> funcs;
   SmallVector<int32_t> priorities;
-  if (auto caInit = dyn_cast<llvm::ConstantArray>(initializer)) {
+  if (isa<llvm::ConstantArray>(initializer)) {
     for (llvm::Value *operand : initializer->operands()) {
       auto *aggregate = dyn_cast<llvm::ConstantAggregate>(operand);
       if (!aggregate || aggregate->getNumOperands() != 3)

mlir/lib/Target/LLVMIR/ModuleTranslation.cpp

@@ -1281,13 +1281,11 @@ LogicalResult ModuleTranslation::convertGlobalsAndAliases() {
                        : llvm::zip(dtorOp.getDtors(), dtorOp.getPriorities());
       auto appendGlobalFn =
           ctorOp ? llvm::appendToGlobalCtors : llvm::appendToGlobalDtors;
-      for (auto symbolAndPriority : range) {
-        llvm::Function *f = lookupFunction(
-            cast<FlatSymbolRefAttr>(std::get<0>(symbolAndPriority)).getValue());
-        appendGlobalFn(
-            *llvmModule, f,
-            cast<IntegerAttr>(std::get<1>(symbolAndPriority)).getInt(),
-            /*Data=*/nullptr);
+      for (const auto &[sym, prio] : range) {
+        llvm::Function *f =
+            lookupFunction(cast<FlatSymbolRefAttr>(sym).getValue());
+        appendGlobalFn(*llvmModule, f, cast<IntegerAttr>(prio).getInt(),
+                       /*Data=*/nullptr);
       }
     }
   }