review: remove INT32_MAX constraint

Author: inbelic

clang/lib/Parse/ParseHLSLRootSignature.cpp

@@ -902,7 +902,7 @@ std::optional<int32_t> RootSignatureParser::handleIntLiteral(bool Negated) {
          "NumSpelling can only consist of digits");
 
   llvm::APSInt Val = llvm::APSInt(32, true);
-  if (Literal.GetIntegerValue(Val) || INT32_MAX < Val.getExtValue()) {
+  if (Literal.GetIntegerValue(Val)) {
     // Report that the value has overflowed
     PP.getDiagnostics().Report(CurToken.TokLoc,
                                diag::err_hlsl_number_literal_overflow)

clang/unittests/Parse/ParseHLSLRootSignatureTest.cpp

@@ -265,6 +265,8 @@ TEST_F(ParseHLSLRootSignatureTest, ValidParseFloatsTest) {
     StaticSampler(s0, mipLODBias = 42.f),
     StaticSampler(s0, mipLODBias = 4.2F),
     StaticSampler(s0, mipLODBias = 42.e+10f),
+    StaticSampler(s0, mipLODBias = -2147483648),
+    StaticSampler(s0, mipLODBias = 2147483648),
   )cc";
 
   TrivialModuleLoader ModLoader;
@@ -324,6 +326,14 @@ TEST_F(ParseHLSLRootSignatureTest, ValidParseFloatsTest) {
   ASSERT_TRUE(std::holds_alternative<StaticSampler>(Elem));
   ASSERT_EQ(std::get<StaticSampler>(Elem).MipLODBias, 420000000000.f);
 
+  Elem = Elements[11];
+  ASSERT_TRUE(std::holds_alternative<StaticSampler>(Elem));
+  ASSERT_FLOAT_EQ(std::get<StaticSampler>(Elem).MipLODBias, -2147483648.f);
+
+  Elem = Elements[12];
+  ASSERT_TRUE(std::holds_alternative<StaticSampler>(Elem));
+  ASSERT_FLOAT_EQ(std::get<StaticSampler>(Elem).MipLODBias, 2147483648.f);
+
   ASSERT_TRUE(Consumer->isSatisfied());
 }