Commit 90e76a3
committed
[lldb][Mach-O] Initialize cputype/cpusubtype in test corefiles
TestFirmwareCorefiles.py has a helper utility, create-empty-corefile.cpp,
which creates corefiles with different metadata to specify the
binary that should be loaded. It normally uses an actual binary's
UUID for the metadata, and it uses the binary's cputype/cpusubtype
for the corefile's mach header.
There is one test where it creates a corefile with metadata for a
UUID that cannot be found -- it is given no binary -- and in that
case, the cputype/cpusubtype it sets in the core file mach header
was uninitialized data. Through luck, on Darwin systems, the
uninitialized data typically matched a CPU_TYPE from machine.h and
the test would work. But when the value doens't match one of thoes
defines, lldb would reject the corefile entirely, and the test would
fail. This has been an infrequent failure on the CI bots for a
while and I couldn't ever repo it. There's a recent configuration
where it was happening every time and I was able to track it down.
rdar://1417275631 parent f334db9 commit 90e76a3
File tree
1 file changed
+8
-0
lines changed- lldb/test/API/macosx/lc-note/firmware-corefile
1 file changed
+8
-0
lines changedLines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
189 | 189 | | |
190 | 190 | | |
191 | 191 | | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
192 | 200 | | |
193 | 201 | | |
194 | 202 | | |
| |||
0 commit comments