[ConstraintElim] Ignore unknown conditions

dtcxzyw · dtcxzyw · commit 919416d2c4c7 · 2024-11-26T22:42:03.000+08:00
diff --git a/llvm/lib/Transforms/Scalar/ConstraintElimination.cpp b/llvm/lib/Transforms/Scalar/ConstraintElimination.cpp
@@ -1536,9 +1536,7 @@ static bool checkOrAndOpImpliedByOther(
              : match(Val, m_LogicalAnd(m_Value(LHS), m_Value(RHS)))) {
       Worklist.push_back(LHS);
       Worklist.push_back(RHS);
-      continue;
     }
-    return false;
   }
   if (OldSize == DFSInStack.size())
     return false;
diff --git a/llvm/test/Transforms/ConstraintElimination/and-implied-by-operands.ll b/llvm/test/Transforms/ConstraintElimination/and-implied-by-operands.ll
@@ -659,7 +659,7 @@ define void @or_tree_second_implies_first_with_unknown_cond(i64 %x, i1 %cond) {
 ; CHECK-NEXT:    [[CMP1:%.*]] = icmp ugt i64 [[X:%.*]], 1
 ; CHECK-NEXT:    [[OR1:%.*]] = select i1 [[CMP1]], i1 [[COND:%.*]], i1 false
 ; CHECK-NEXT:    [[CMP2:%.*]] = icmp ult i64 [[X]], 2
-; CHECK-NEXT:    [[OR2:%.*]] = select i1 [[OR1]], i1 [[CMP2]], i1 false
+; CHECK-NEXT:    [[OR2:%.*]] = select i1 [[OR1]], i1 false, i1 false
 ; CHECK-NEXT:    br i1 [[OR2]], label [[IF_THEN:%.*]], label [[IF_END:%.*]]
 ; CHECK:       if.then:
 ; CHECK-NEXT:    call void @side_effect()

Original file line number	Diff line number	Diff line change
`@@ -1536,9 +1536,7 @@ static bool checkOrAndOpImpliedByOther(`
`1536`	`1536`	`: match(Val, m_LogicalAnd(m_Value(LHS), m_Value(RHS)))) {`
`1537`	`1537`	`Worklist.push_back(LHS);`
`1538`	`1538`	`Worklist.push_back(RHS);`
`1539`		`- continue;`
`1540`	`1539`	`}`
`1541`		`- return false;`
`1542`	`1540`	`}`
`1543`	`1541`	`if (OldSize == DFSInStack.size())`
`1544`	`1542`	`return false;`