Remove legacy error checking Pt 1

Author: adurang

offload/plugins-nextgen/level_zero/include/L0Device.h

@@ -258,12 +258,6 @@ class L0DeviceTy final : public GenericDeviceTy {
   /// The current size of the global device memory pool (managed by us).
   uint64_t HeapSize = 1L << 23L /*8MB=*/;
 
-  int32_t synchronize(__tgt_async_info *AsyncInfo, bool ReleaseQueue = true);
-  int32_t submitData(void *TgtPtr, const void *HstPtr, int64_t Size,
-                     __tgt_async_info *AsyncInfo);
-  int32_t retrieveData(void *HstPtr, const void *TgtPtr, int64_t Size,
-                       __tgt_async_info *AsyncInfo);
-
   bool shouldSetupDeviceMemoryPool() const override { return false; }
   DeviceArchTy computeArch() const;
 
@@ -336,13 +330,12 @@ class L0DeviceTy final : public GenericDeviceTy {
     return nullptr;
   }
 
-  int32_t buildAllKernels() {
+  Error buildAllKernels() {
     for (auto &PGM : Programs) {
-      int32_t RC = PGM.loadModuleKernels();
-      if (RC != OFFLOAD_SUCCESS)
-        return RC;
+      if (auto Err = PGM.loadModuleKernels())
+        return Err;
     }
-    return OFFLOAD_SUCCESS;
+    return Plugin::success();
   }
 
   // add a new program to the device. Return a reference to the new program
@@ -488,17 +481,17 @@ class L0DeviceTy final : public GenericDeviceTy {
   ze_command_list_handle_t getImmCopyCmdList();
 
   /// Enqueue copy command
-  int32_t enqueueMemCopy(void *Dst, const void *Src, size_t Size,
-                         __tgt_async_info *AsyncInfo = nullptr,
-                         bool UseCopyEngine = true);
+  Error enqueueMemCopy(void *Dst, const void *Src, size_t Size,
+                       __tgt_async_info *AsyncInfo = nullptr,
+                       bool UseCopyEngine = true);
 
   /// Enqueue asynchronous copy command
-  int32_t enqueueMemCopyAsync(void *Dst, const void *Src, size_t Size,
-                              __tgt_async_info *AsyncInfo, bool CopyTo = true);
+  Error enqueueMemCopyAsync(void *Dst, const void *Src, size_t Size,
+                            __tgt_async_info *AsyncInfo, bool CopyTo = true);
 
   /// Enqueue fill command
-  int32_t enqueueMemFill(void *Ptr, const void *Pattern, size_t PatternSize,
-                         size_t Size);
+  Error enqueueMemFill(void *Ptr, const void *Pattern, size_t PatternSize,
+                       size_t Size);
 
   /// Driver related functions
 

offload/plugins-nextgen/level_zero/include/L0Memory.h

@@ -388,10 +388,10 @@ class MemAllocatorTy {
   }
 
   /// Perform copy operation
-  int32_t enqueueMemCopy(void *Dst, const void *Src, size_t Size);
+  Error enqueueMemCopy(void *Dst, const void *Src, size_t Size);
 
   /// Perform memory fill operation
-  int32_t enqueueMemSet(void *Dst, int8_t Value, size_t Size);
+  Error enqueueMemSet(void *Dst, int8_t Value, size_t Size);
 
 }; /// MemAllocatorTy
 
@@ -517,7 +517,7 @@ class StagingBufferTy {
   StagingBufferTy &operator=(const StagingBufferTy &) = delete;
   StagingBufferTy &operator=(const StagingBufferTy &&) = delete;
 
-  ~StagingBufferTy() { }
+  ~StagingBufferTy() {}
 
   void clear() {
     ze_result_t Rc;

offload/plugins-nextgen/level_zero/include/L0Program.h

@@ -56,9 +56,9 @@ class L0ProgramTy : public DeviceImageTy {
   bool IsLibModule = false;
 
   /// Build a single module with the given image, build option, and format.
-  int32_t addModule(const size_t Size, const uint8_t *Image,
-                    const std::string_view BuildOption,
-                    ze_module_format_t Format);
+  Error addModule(const size_t Size, const uint8_t *Image,
+                  const std::string_view BuildOption,
+                  ze_module_format_t Format);
   /// Read file and return the size of the binary if successful.
   size_t readFile(const char *FileName, std::vector<uint8_t> &OutFile) const;
   void replaceDriverOptsWithBackendOpts(const L0DeviceTy &Device,
@@ -89,22 +89,21 @@ class L0ProgramTy : public DeviceImageTy {
   }
 
   /// Build modules from the target image description
-  int32_t buildModules(const std::string_view BuildOptions);
+  Error buildModules(const std::string_view BuildOptions);
 
   /// Link modules stored in \p Modules.
-  int32_t linkModules();
+  Error linkModules();
 
   /// Loads the kernels names from all modules
-  int32_t loadModuleKernels();
+  Error loadModuleKernels();
 
   /// Read data from the location in the device image which corresponds to the
   /// specified global variable name.
-  int32_t readGlobalVariable(const char *Name, size_t Size, void *HostPtr);
+  Error readGlobalVariable(const char *Name, size_t Size, void *HostPtr);
 
   /// Write data to the location in the device image which corresponds to the
   /// specified global variable name.
-  int32_t writeGlobalVariable(const char *Name, size_t Size,
-                              const void *HostPtr);
+  Error writeGlobalVariable(const char *Name, size_t Size, const void *HostPtr);
 
   /// Looks up an OpenMP declare target global variable with the given
   /// \p Name and \p Size in the device environment for the current device.

offload/plugins-nextgen/level_zero/include/L0Trace.h

@@ -70,6 +70,11 @@
   CALL_ZE_RET_MTX(NULL, Fn, Mtx, __VA_ARGS__)
 #define CALL_ZE_RET_ZERO_MTX(Fn, Mtx, ...)                                     \
   CALL_ZE_RET_MTX(0, Fn, Mtx, __VA_ARGS__)
+#define CALL_ZE_RET_ERROR_MTX(Fn, Mtx, ...)                                   \
+  CALL_ZE_RET_MTX(                                                            \
+    Plugin::error(ErrorCode::UNKNOWN, "%s failed with error %d, %s",          \
+    STR(Fn), rc, getZeErrorName(rc)), Fn, Mtx, __VA_ARGS__)
+
 
 /// For thread-safe functions
 #define CALL_ZE_RET(Ret, Fn, ...)                                              \