Addressed Review comments

Author: Chandra Ghale

clang/include/clang/AST/OpenMPClause.h

@@ -3772,7 +3772,7 @@ class OMPReductionClause final
   void setPrivateVariableReductionFlags(ArrayRef<bool> Flags) {
     assert(Flags.size() == varlist_size() &&
            "Number of private flags does not match vars");
-    std::copy(Flags.begin(), Flags.end(), getTrailingObjects<bool>());
+    llvm::copy(Flags,getTrailingObjects<bool>());
   }
 
   /// Get the list of help private variable reduction flags

clang/lib/Sema/SemaOpenMP.cpp

@@ -18955,18 +18955,16 @@ static bool actOnOMPReductionKindClause(
       OpenMPDirectiveKind CurrDir = Stack->getCurrentDirective();
       OpenMPDirectiveKind ParentDir = Stack->getParentDirective();
       // Check if the construct is orphaned (has no enclosing OpenMP context)
-      IsOrphaned = (ParentDir == OMPD_unknown);
-      IsPrivate =
+      IsOrphaned = ParentDir == OMPD_unknown;
+      // OpenMP 6.0: Private DSA check
+      IsPrivate = (S.getLangOpts().OpenMP > 52) &&
           ((isOpenMPPrivate(DVar.CKind) && DVar.CKind != OMPC_reduction &&
             isOpenMPWorksharingDirective(CurrDir) &&
             !isOpenMPParallelDirective(CurrDir) &&
             !isOpenMPTeamsDirective(CurrDir) &&
             !isOpenMPSimdDirective(ParentDir)) ||
            (IsOrphaned && DVar.CKind == OMPC_unknown) ||
            RD.OrigSharingModifier != OMPC_ORIGINAL_SHARING_shared);
-      // Disable private handling for OpenMP versions <= 5.2
-      if (S.getLangOpts().OpenMP <= 52)
-        IsPrivate = false;
 
       // OpenMP [2.14.3.6, Restrictions, p.1]
       //  A list item that appears in a reduction clause of a worksharing

clang/lib/Serialization/ASTReader.cpp

@@ -11724,7 +11724,7 @@ void OMPClauseReader::VisitOMPReductionClause(OMPReductionClause *C) {
   unsigned NumFlags = Record.readInt();
   SmallVector<bool, 16> Flags;
   Flags.reserve(NumFlags);
-  for (unsigned i = 0; i != NumFlags; ++i)
+  for (unsigned I : llvm::seq<unsigned>(NumFlags))
     Flags.push_back(Record.readInt());
   C->setPrivateVariableReductionFlags(Flags);
 }

clang/lib/Serialization/ASTWriter.cpp

@@ -8022,7 +8022,6 @@ void OMPClauseWriter::VisitOMPReductionClause(OMPReductionClause *C) {
   }
   auto PrivateFlags = C->private_var_reduction_flags();
   Record.push_back(std::distance(PrivateFlags.begin(), PrivateFlags.end()));
-  // Record.push_back(PrivateFlags.size());
   for (bool Flag : PrivateFlags)
     Record.push_back(Flag);
 }