Skip to content

Commit 926f24c

Browse files
committed
Adress review comments
1 parent a888d84 commit 926f24c

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4164,7 +4164,7 @@ defm BFMAX_ZPZZ : sve_fp_2op_p_zds_zeroing_bfloat<int_aarch64_sve_fmax>;
41644164
} // HasSVEB16B16, UseExperimentalZeroingPseudos
41654165

41664166
let Predicates = [HasSVEBFSCALE] in {
4167-
def BFSCALE_ZPZZ : sve_fp_2op_p_zds_bfscale<0b1001, "bfscale", DestructiveBinaryComm>;
4167+
def BFSCALE_ZPZZ : sve_fp_2op_p_zds_bfscale<0b1001, "bfscale", DestructiveBinary>;
41684168
} // HasSVEBFSCALE
41694169
//===----------------------------------------------------------------------===//
41704170
// SME2.1 or SVE2.1 instructions

llvm/lib/Target/AArch64/SVEInstrFormats.td

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2174,9 +2174,10 @@ multiclass sve_fp_2op_p_zds_bfloat<bits<4> opc, string asm, string Ps,
21742174
def : SVE_3_Op_Pat<nxv8bf16, op, nxv8i1, nxv8bf16, nxv8bf16, !cast<Instruction>(NAME)>;
21752175
}
21762176

2177-
class sve_fp_2op_p_zds_bfscale<bits<4> opc, string asm, DestructiveInstTypeEnum flags> : sve_fp_2op_p_zds<0b00, opc, asm, ZPR16>{
2178-
let DestructiveInstType = flags;
2179-
}
2177+
class sve_fp_2op_p_zds_bfscale<bits<4> opc, string asm, DestructiveInstTypeEnum flags>
2178+
: sve_fp_2op_p_zds<0b00, opc, asm, ZPR16>{
2179+
let DestructiveInstType = flags;
2180+
}
21802181

21812182
multiclass sve_fp_2op_p_zds_zeroing_hsd<SDPatternOperator op> {
21822183
def _H_ZERO : PredTwoOpPseudo<NAME # _H, ZPR16, FalseLanesZero>;

llvm/test/MC/AArch64/SVE2/directive-cpu.s

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,5 @@ bgrp z21.s, z10.s, z21.s
2222

2323
.cpu generic+sve-bfscale
2424
bfscale z0.h, p0/m, z0.h, z0.h
25-
// CHECK-d: error: instruction requires: sve-bfscale
26-
// CHECK: bfscale z0.h, p0/m, z0.h, z0.h
25+
// CHECK: error: instruction requires: sve-bfscale
26+
// CHECK-NEXT: bfscale z0.h, p0/m, z0.h, z0.h

0 commit comments

Comments
 (0)