Address review feedback

Created using spr 1.3.5

Author: cachemeifyoucan

llvm/include/llvm/CAS/ObjectStore.h

@@ -217,10 +217,6 @@ class ObjectStore {
   /// Validate the whole node tree.
   Error validateTree(ObjectRef Ref);
 
-  /// Print the ObjectStore internals for debugging purpose.
-  virtual void print(raw_ostream &) const {}
-  void dump() const;
-
   /// Get CASContext
   const CASContext &getContext() const { return Context; }
 

llvm/lib/CAS/ObjectStore.cpp

@@ -21,7 +21,6 @@ void CASContext::anchor() {}
 void ObjectStore::anchor() {}
 
 LLVM_DUMP_METHOD void CASID::dump() const { print(dbgs()); }
-LLVM_DUMP_METHOD void ObjectStore::dump() const { print(dbgs()); }
 LLVM_DUMP_METHOD void ObjectRef::dump() const { print(dbgs()); }
 LLVM_DUMP_METHOD void ObjectHandle::dump() const { print(dbgs()); }
 

llvm/unittests/CAS/ObjectStoreTest.cpp

@@ -183,11 +183,10 @@ multiline text multiline text multiline text multiline text multiline text)",
 
     // Check basic printing of IDs.
     IDs.push_back(CAS1->getID(*Node));
-    EXPECT_EQ(IDs.back().toString(), IDs.back().toString());
-    EXPECT_EQ(Nodes.front(), Nodes.front());
-    EXPECT_EQ(Nodes.back(), Nodes.back());
-    EXPECT_EQ(IDs.front(), IDs.front());
-    EXPECT_EQ(IDs.back(), IDs.back());
+    auto ID = CAS1->getID(Nodes.back());
+    EXPECT_EQ(ID.toString(), IDs.back().toString());
+    EXPECT_EQ(*Node, Nodes.back());
+    EXPECT_EQ(ID, IDs.back());
     if (Nodes.size() <= 1)
       continue;
     EXPECT_NE(Nodes.front(), Nodes.back());