Update relocateOneCompactUnwindEntry, don't get address in it, it might be invalid.

Signed-off-by: Peter Rong <[email protected]>

Author: DataCorrupted

lld/MachO/BPSectionOrderer.cpp

@@ -62,7 +62,6 @@ getRelocHash(const Reloc &reloc,
 }
 
 // Get a hash of the unwind info (after relocation).
-// This hash is not 100% accurate, but it's good enough for compression.
 //
 // Unwind info will be eliminated if it is the same as its neighbors.
 // We want to order functions such that the ones with similar unwind info

lld/MachO/UnwindInfoSection.cpp

@@ -111,7 +111,6 @@ CREATE_LAYOUT_CLASS(CompactUnwind, FOR_EACH_CU_FIELD);
 
 void lld::macho::CompactUnwindEntry::relocateOneCompactUnwindEntry(
     const Defined *d) {
-  functionAddress = d->getVA();
 
   ConcatInputSection *unwindEntry = d->unwindEntry();
   if (!unwindEntry)
@@ -389,7 +388,9 @@ Symbol *UnwindInfoSectionImpl::canonicalizePersonality(Symbol *personality) {
 void UnwindInfoSectionImpl::relocateCompactUnwind(
     std::vector<CompactUnwindEntry> &cuEntries) {
   parallelFor(0, symbolsVec.size(), [&](size_t i) {
-    cuEntries[i].relocateOneCompactUnwindEntry(symbolsVec[i].second);
+    const Defined *d = symbolsVec[i].second;
+    cuEntries[i].functionAddress = d->getVA();
+    cuEntries[i].relocateOneCompactUnwindEntry(d);
   });
 }
 

lld/MachO/UnwindInfoSection.h

@@ -39,8 +39,8 @@ struct CompactUnwindEntry {
   uint64_t functionAddress;
   uint32_t functionLength;
   compact_unwind_encoding_t encoding;
-  Symbol *personality;
-  InputSection *lsda;
+  Symbol *personality = nullptr;
+  InputSection *lsda = nullptr;
 
   // Relocate the entry to the given Symbol.
   void relocateOneCompactUnwindEntry(const Defined *d);