Skip to content

Commit 93d24b6

Browse files
authored
[NFC][PGO] Drop unused Module parameter in setProfMetadata (#153733)
1 parent bf2f241 commit 93d24b6

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

llvm/include/llvm/Transforms/Instrumentation/PGOInstrumentation.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,8 @@ class PGOMemOPSizeOpt : public PassInfoMixin<PGOMemOPSizeOpt> {
104104
LLVM_ABI PreservedAnalyses run(Function &F, FunctionAnalysisManager &MAM);
105105
};
106106

107-
LLVM_ABI void setProfMetadata(Module *M, Instruction *TI,
108-
ArrayRef<uint64_t> EdgeCounts, uint64_t MaxCount);
107+
LLVM_ABI void setProfMetadata(Instruction *TI, ArrayRef<uint64_t> EdgeCounts,
108+
uint64_t MaxCount);
109109

110110
LLVM_ABI void setIrrLoopHeaderMetadata(Module *M, Instruction *TI,
111111
uint64_t Count);

llvm/lib/Transforms/Instrumentation/PGOCtxProfFlattening.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ void assignProfileData(Function &F, ArrayRef<uint64_t> RawCounters) {
5858
uint64_t TrueCount, FalseCount = 0;
5959
if (!PA.getSelectInstrProfile(*SI, TrueCount, FalseCount))
6060
continue;
61-
setProfMetadata(F.getParent(), SI, {TrueCount, FalseCount},
61+
setProfMetadata(SI, {TrueCount, FalseCount},
6262
std::max(TrueCount, FalseCount));
6363
}
6464
if (succ_size(&BB) < 2)
@@ -67,7 +67,7 @@ void assignProfileData(Function &F, ArrayRef<uint64_t> RawCounters) {
6767
if (!PA.getOutgoingBranchWeights(BB, ProfileHolder, MaxCount))
6868
continue;
6969
assert(MaxCount > 0);
70-
setProfMetadata(F.getParent(), BB.getTerminator(), ProfileHolder, MaxCount);
70+
setProfMetadata(BB.getTerminator(), ProfileHolder, MaxCount);
7171
}
7272
}
7373

llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1727,7 +1727,7 @@ void PGOUseFunc::setBranchWeights() {
17271727
}
17281728

17291729
if (MaxCount)
1730-
setProfMetadata(M, TI, EdgeCounts, MaxCount);
1730+
setProfMetadata(TI, EdgeCounts, MaxCount);
17311731
else {
17321732
// A zero MaxCount can come about when we have a BB with a positive
17331733
// count, and whose successor blocks all have 0 count. This can happen
@@ -1801,7 +1801,7 @@ void SelectInstVisitor::annotateOneSelectInst(SelectInst &SI) {
18011801
SCounts[1] = (TotalCount > SCounts[0] ? TotalCount - SCounts[0] : 0);
18021802
uint64_t MaxCount = std::max(SCounts[0], SCounts[1]);
18031803
if (MaxCount)
1804-
setProfMetadata(F.getParent(), &SI, SCounts, MaxCount);
1804+
setProfMetadata(&SI, SCounts, MaxCount);
18051805
}
18061806

18071807
void SelectInstVisitor::visitSelectInst(SelectInst &SI) {
@@ -2407,8 +2407,8 @@ static std::string getSimpleNodeName(const BasicBlock *Node) {
24072407
return SimpleNodeName;
24082408
}
24092409

2410-
void llvm::setProfMetadata(Module *M, Instruction *TI,
2411-
ArrayRef<uint64_t> EdgeCounts, uint64_t MaxCount) {
2410+
void llvm::setProfMetadata(Instruction *TI, ArrayRef<uint64_t> EdgeCounts,
2411+
uint64_t MaxCount) {
24122412
assert(MaxCount > 0 && "Bad max count");
24132413
uint64_t Scale = calculateCountScale(MaxCount);
24142414
SmallVector<unsigned, 4> Weights;

llvm/lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,7 @@ bool MemOPSizeOpt::perform(MemOp MO) {
432432
Updates.clear();
433433

434434
if (MaxCount)
435-
setProfMetadata(Func.getParent(), SI, CaseCounts, MaxCount);
435+
setProfMetadata(SI, CaseCounts, MaxCount);
436436

437437
LLVM_DEBUG(dbgs() << *BB << "\n");
438438
LLVM_DEBUG(dbgs() << *DefaultBB << "\n");

0 commit comments

Comments
 (0)