[InstCombine] fix hwasan mistake in "remove dead loads" (#145057)

vtjnash · web-flow · commit 940ff110d78b · 2025-06-20T12:22:59.000-04:00
Detected by CI after #143958.
diff --git a/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp b/llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
@@ -3490,6 +3490,7 @@ Instruction *InstCombinerImpl::visitAllocSite(Instruction &MI) {
           replaceInstUsesWith(*I, Result);
           eraseInstFromFunction(*I);
           Users[i] = nullptr; // Skip examining in the next loop.
+          continue;
         }
         if (auto *MTI = dyn_cast<MemTransferInst>(I)) {
           if (KnowInitZero && isRefSet(*Removable)) {

Original file line number	Diff line number	Diff line change
`@@ -3490,6 +3490,7 @@ Instruction *InstCombinerImpl::visitAllocSite(Instruction &MI) {`
`3490`	`3490`	`replaceInstUsesWith(*I, Result);`
`3491`	`3491`	`eraseInstFromFunction(*I);`
`3492`	`3492`	`Users[i] = nullptr; // Skip examining in the next loop.`
	`3493`	`+ continue;`
`3493`	`3494`	`}`
`3494`	`3495`	`if (auto *MTI = dyn_cast<MemTransferInst>(I)) {`
`3495`	`3496`	`if (KnowInitZero && isRefSet(*Removable)) {`