Skip to content

Commit 945a908

Browse files
committed
fixup! fixup! [llvm][docs] Add notes on upstreaming code from downstream projects
Include suggestion from Hubert
1 parent 7e51343 commit 945a908

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

llvm/docs/CodeReview.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -286,5 +286,5 @@ When upstreaming changes originally written by someone else:
286286
* Properly attribute the original changes, e.g., by creating a commit with
287287
multiple authors ([GitHub guide](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors)).
288288
* Invite the original author(s) to review the changes, and also include
289-
additional reviewers. Specifically, an LGTM from a (co-)author does not
290-
constitute approval to land a change.
289+
additional reviewers. Specifically, an LGTM from a (co-)author should not be
290+
taken as approval to land a change.

0 commit comments

Comments
 (0)