We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent 7e51343 commit 945a908Copy full SHA for 945a908
llvm/docs/CodeReview.rst
@@ -286,5 +286,5 @@ When upstreaming changes originally written by someone else:
286
* Properly attribute the original changes, e.g., by creating a commit with
287
multiple authors ([GitHub guide](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors)).
288
* Invite the original author(s) to review the changes, and also include
289
- additional reviewers. Specifically, an LGTM from a (co-)author does not
290
- constitute approval to land a change.
+ additional reviewers. Specifically, an LGTM from a (co-)author should not be
+ taken as approval to land a change.
0 commit comments