[mlir][mesh] Exit after signalPassFailure to fix a crash (#132662)

CoTinker · web-flow · commit 94783a8199c5 · 2025-03-24T20:19:56.000+08:00
Fixes #131435.
diff --git a/mlir/lib/Dialect/Mesh/Transforms/ShardingPropagation.cpp b/mlir/lib/Dialect/Mesh/Transforms/ShardingPropagation.cpp
@@ -369,7 +369,7 @@ struct ShardingPropagation
     OpBuilder builder(ctx);
     if (!region.hasOneBlock()) {
       funcOp.emitOpError() << "only one block is supported!";
-      signalPassFailure();
+      return signalPassFailure();
     }
     Block &block = region.front();
 
diff --git a/mlir/test/Dialect/Mesh/sharding-propagation-failed.mlir b/mlir/test/Dialect/Mesh/sharding-propagation-failed.mlir
@@ -0,0 +1,4 @@
+// RUN: mlir-opt --pass-pipeline="builtin.module(func.func(sharding-propagation))" %s -verify-diagnostics
+
+// expected-error @+1 {{'func.func' op only one block is supported!}}
+func.func private @no_block_function(i64)

Original file line number	Diff line number	Diff line change
`@@ -369,7 +369,7 @@ struct ShardingPropagation`
`369`	`369`	`OpBuilder builder(ctx);`
`370`	`370`	`if (!region.hasOneBlock()) {`
`371`	`371`	`funcOp.emitOpError() << "only one block is supported!";`
`372`		`- signalPassFailure();`
	`372`	`+ return signalPassFailure();`
`373`	`373`	`}`
`374`	`374`	`Block &block = region.front();`
`375`	`375`