Skip to content

Commit 94c05f0

Browse files
committed
Address code review comments
1 parent 4509f80 commit 94c05f0

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

clang/lib/CIR/CodeGen/CIRGenExprAggregate.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -576,7 +576,7 @@ void AggExprEmitter::emitNullInitializationToLValue(mlir::Location loc,
576576
return;
577577
}
578578

579-
cgf.emitStoreThroughBitfieldLValue(RValue::get(null), lv);
579+
cgf.cgm.errorNYI("emitStoreThroughBitfieldLValue");
580580
return;
581581
}
582582

clang/test/CIR/CodeGen/struct.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,8 @@ void compound_literal_expr() { CompleteS a = (CompleteS){}; }
291291
// CIR: %[[CONST_0:.*]] = cir.const #cir.int<0> : !s8i
292292
// CIR: cir.store{{.*}} %[[CONST_0]], %[[A_ELEM_1_PTR]] : !s8i, !cir.ptr<!s8i>
293293

294+
// TODO(cir): zero-initialize the padding
295+
294296
// LLVM: %[[A_ADDR:.*]] = alloca %struct.CompleteS, i64 1, align 4
295297
// LLVM: %[[A_ELEM_0_PTR:.*]] = getelementptr %struct.CompleteS, ptr %[[A_ADDR]], i32 0, i32 0
296298
// LLVM: store i32 0, ptr %[[A_ELEM_0_PTR]], align 4

0 commit comments

Comments
 (0)