moved test impl

Author: nikalra

mlir/test/python/ir/diagnostic_handler.py

@@ -3,7 +3,7 @@
 import gc
 from mlir.ir import *
 from mlir._mlir_libs._mlirPythonTestNanobind import (
-  test_diagnostics_with_errors_and_notes,
+    test_diagnostics_with_errors_and_notes,
 )
 
 
@@ -236,5 +236,5 @@ def testBuiltInDiagnosticsHandler():
         test_diagnostics_with_errors_and_notes(ctx)
     except ValueError as e:
         # CHECK: created error
-        # CHECK: MLIRPythonCAPI
+        # CHECK: attached note
         print(e)

mlir/test/python/lib/PythonTestCAPI.cpp

@@ -11,6 +11,8 @@
 #include "mlir-c/BuiltinTypes.h"
 #include "mlir/CAPI/Registration.h"
 #include "mlir/CAPI/Wrap.h"
+#include "mlir/IR/Diagnostics.h"
+#include "mlir/IR/Location.h"
 
 MLIR_DEFINE_CAPI_DIALECT_REGISTRATION(PythonTest, python_test,
                                       python_test::PythonTestDialect)
@@ -42,3 +44,9 @@ MlirTypeID mlirPythonTestTestTypeGetTypeID(void) {
 bool mlirTypeIsAPythonTestTestTensorValue(MlirValue value) {
   return mlirTypeIsATensor(wrap(unwrap(value).getType()));
 }
+
+void mlirPythonTestEmitDiagnosticWithNote(MlirContext ctx) {
+  auto diag =
+      mlir::emitError(unwrap(mlirLocationUnknownGet(ctx)), "created error");
+  diag.attachNote() << "attached note";
+}

mlir/test/python/lib/PythonTestCAPI.h

@@ -10,6 +10,7 @@
 #define MLIR_TEST_PYTHON_LIB_PYTHONTESTCAPI_H
 
 #include "mlir-c/IR.h"
+#include "mlir-c/Support.h"
 
 #ifdef __cplusplus
 extern "C" {
@@ -33,6 +34,8 @@ MLIR_CAPI_EXPORTED MlirTypeID mlirPythonTestTestTypeGetTypeID(void);
 
 MLIR_CAPI_EXPORTED bool mlirTypeIsAPythonTestTestTensorValue(MlirValue value);
 
+MLIR_CAPI_EXPORTED void mlirPythonTestEmitDiagnosticWithNote(MlirContext ctx);
+
 #ifdef __cplusplus
 }
 #endif

mlir/test/python/lib/PythonTestModuleNanobind.cpp

@@ -52,8 +52,7 @@ NB_MODULE(_mlirPythonTestNanobind, m) {
     mlirContextPrintStackTraceOnDiagnostic(ctx, true);
     mlir::python::CollectDiagnosticsToStringScope handler(ctx);
 
-    auto loc = mlirLocationUnknownGet(ctx);
-    mlirEmitError(loc, "created error");
+    mlirPythonTestEmitDiagnosticWithNote(ctx);
     throw nb::value_error(handler.takeMessage().c_str());
   });