Skip to content

Commit 953ea5e

Browse files
committed
Remove some std::string instantiation benchmarks to reduce total time
1 parent 823b92e commit 953ea5e

File tree

4 files changed

+0
-9
lines changed

4 files changed

+0
-9
lines changed

libcxx/test/benchmarks/containers/associative/associative_container_benchmarks.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ void associative_container_benchmarks(std::string container) {
5757
auto get_key = [](Value const& v) { return adapt_operations<Container>::key_from_value(v); };
5858

5959
auto bench = [&](std::string operation, auto f) {
60-
// Note: Add zero to the range for empty containers.
6160
benchmark::RegisterBenchmark(container + "::" + operation, f)->Arg(0)->Arg(32)->Arg(1024)->Arg(8192);
6261
};
6362

@@ -173,7 +172,6 @@ void associative_container_benchmarks(std::string container) {
173172
// Insertion
174173
/////////////////////////
175174
bench("insert(value) (already present)", [=](auto& st) {
176-
// Make sure non-empty container for |to_insert| to be present and no segfault.
177175
const std::size_t size = st.range(0) ? st.range(0) : 1;
178176
std::vector<Value> in = make_value_types(generate_unique_keys(size));
179177
Value to_insert = in[in.size() / 2]; // pick any existing value

libcxx/test/benchmarks/containers/associative/unordered_map.bench.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ struct support::adapt_operations<std::unordered_map<K, V>> {
2828

2929
int main(int argc, char** argv) {
3030
support::associative_container_benchmarks<std::unordered_map<int, int>>("std::unordered_map<int, int>");
31-
support::associative_container_benchmarks<std::unordered_map<std::string, int>>(
32-
"std::unordered_map<std::string, int>");
3331

3432
benchmark::Initialize(&argc, argv);
3533
benchmark::RunSpecifiedBenchmarks();

libcxx/test/benchmarks/containers/associative/unordered_multimap.bench.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ struct support::adapt_operations<std::unordered_multimap<K, V>> {
2727

2828
int main(int argc, char** argv) {
2929
support::associative_container_benchmarks<std::unordered_multimap<int, int>>("std::unordered_multimap<int, int>");
30-
support::associative_container_benchmarks<std::unordered_multimap<std::string, int>>(
31-
"std::unordered_multimap<std::string, int>");
3230

3331
benchmark::Initialize(&argc, argv);
3432
benchmark::RunSpecifiedBenchmarks();

libcxx/test/benchmarks/containers/associative/unordered_multiset.bench.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
// UNSUPPORTED: c++03, c++11, c++14, c++17
1010

11-
#include <string>
1211
#include <unordered_set>
1312

1413
#include "associative_container_benchmarks.h"
@@ -27,8 +26,6 @@ struct support::adapt_operations<std::unordered_multiset<K>> {
2726

2827
int main(int argc, char** argv) {
2928
support::associative_container_benchmarks<std::unordered_multiset<int>>("std::unordered_multiset<int>");
30-
support::associative_container_benchmarks<std::unordered_multiset<std::string>>(
31-
"std::unordered_multiset<std::string>");
3229

3330
benchmark::Initialize(&argc, argv);
3431
benchmark::RunSpecifiedBenchmarks();

0 commit comments

Comments
 (0)