Skip to content

Commit 9573f23

Browse files
committed
Address review comment
1 parent fee7dc8 commit 9573f23

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

llvm/lib/Target/RISCV/RISCVISelLowering.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4573,9 +4573,9 @@ static SDValue lowerScalarInsert(SDValue Scalar, SDValue VL, MVT VT,
45734573
/// vector source, return it. Note that the source may be larger
45744574
/// than the requested concat_vector (i.e. a extract_subvector
45754575
/// might be required.)
4576-
static SDValue FoldConcatVector(SDValue V1, SDValue V2) {
4576+
static SDValue foldConcatVector(SDValue V1, SDValue V2) {
45774577
EVT VT = V1.getValueType();
4578-
assert(VT == V1.getValueType() && "precondition");
4578+
assert(VT == V2.getValueType() && "argument types must match");
45794579
// Both input must be extracts.
45804580
if (V1.getOpcode() != ISD::EXTRACT_SUBVECTOR ||
45814581
V2.getOpcode() != ISD::EXTRACT_SUBVECTOR)
@@ -4604,7 +4604,7 @@ static SDValue getSingleShuffleSrc(MVT VT, SDValue V1, SDValue V2) {
46044604
unsigned NumElts = VT.getVectorNumElements();
46054605
// Src needs to have twice the number of elements.
46064606
// TODO: Update shuffle lowering to add the extract subvector
4607-
if (SDValue Src = FoldConcatVector(V1, V2);
4607+
if (SDValue Src = foldConcatVector(V1, V2);
46084608
Src && Src.getValueType().getVectorNumElements() == (NumElts * 2))
46094609
return Src;
46104610

@@ -11529,7 +11529,7 @@ SDValue RISCVTargetLowering::lowerVECTOR_DEINTERLEAVE(SDValue Op,
1152911529

1153011530
// For fractional LMUL, check if we can use a higher LMUL
1153111531
// instruction to avoid a vslidedown.
11532-
if (SDValue Src = FoldConcatVector(V1, V2);
11532+
if (SDValue Src = foldConcatVector(V1, V2);
1153311533
Src && getLMUL1VT(VT).bitsGT(VT)) {
1153411534
EVT NewVT = VT.getDoubleNumVectorElementsVT();
1153511535
SDValue ZeroIdx = DAG.getVectorIdxConstant(0, DL);

0 commit comments

Comments
 (0)