Skip to content

Commit 95d71aa

Browse files
committed
[mlir] Add non-attribute property predicates to adaptor verifiers
When adding a predicated field to non-attribute properties / implemneting PropConstraint, a call to genPropertyVerifiers() wasn't added to the generation sequence for [Op]GenericAdaptor::verify. This commit fixes the issue.
1 parent a100f63 commit 95d71aa

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1127,7 +1127,7 @@ static void genPropertyVerifier(
11271127
body << formatv(fetchProperty, varName, getterName,
11281128
prop.prop.getInterfaceType());
11291129
auto uniquedFn = staticVerifierEmitter.getPropConstraintFn(prop.prop);
1130-
if (uniquedFn.has_value())
1130+
if (uniquedFn.has_value() && emitHelper.isEmittingForOp())
11311131
body << formatv(verifyPropertyUniqued, *uniquedFn, varName, prop.name);
11321132
else
11331133
body << formatv(
@@ -4764,6 +4764,7 @@ void OpOperandAdaptorEmitter::addVerification() {
47644764

47654765
FmtContext verifyCtx;
47664766
populateSubstitutions(emitHelper, verifyCtx);
4767+
genPropertyVerifier(emitHelper, verifyCtx, body, staticVerifierEmitter);
47674768
genAttributeVerifier(emitHelper, verifyCtx, body, staticVerifierEmitter,
47684769
useProperties);
47694770

0 commit comments

Comments
 (0)