Change all tests to use ifdef guards

alyyelashram · AlyElashram · commit 961cbce6348e · 2025-05-31T01:42:03.000+03:00
diff --git a/libc/test/src/string/memchr_test.cpp b/libc/test/src/string/memchr_test.cpp
@@ -122,7 +122,7 @@ TEST(LlvmLibcMemChrTest, SignedCharacterFound) {
   ASSERT_EQ(actual[0], c);
 }
 
-#if defined(LIBC_TARGET_OS_IS_LINUX)
+#ifdef LIBC_TARGET_OS_IS_LINUX
 
 TEST(LlvmLibcMemChrTest, CrashOnNullPtr) {
   ASSERT_DEATH([]() { LIBC_NAMESPACE::memchr(nullptr, 1, 1); },
diff --git a/libc/test/src/string/memcmp_test.cpp b/libc/test/src/string/memcmp_test.cpp
@@ -66,7 +66,7 @@ TEST(LlvmLibcMemcmpTest, SizeSweep) {
   }
 }
 
-#if defined(LIBC_TARGET_OS_IS_LINUX)
+#ifdef LIBC_TARGET_OS_IS_LINUX
 
 TEST(LlvmLibcMemcmpTest, CrashOnNullPtr) {
   ASSERT_DEATH([]() { LIBC_NAMESPACE::memcmp(nullptr, nullptr, 1); },
diff --git a/libc/test/src/string/memcpy_test.cpp b/libc/test/src/string/memcpy_test.cpp
@@ -73,7 +73,7 @@ TEST(LlvmLibcMemcpyTest, CheckAccess) {
 
 #endif // !defined(LIBC_FULL_BUILD) && defined(LIBC_TARGET_OS_IS_LINUX)
 
-#if defined(LIBC_TARGET_OS_IS_LINUX)
+#ifdef LIBC_TARGET_OS_IS_LINUX
 
 TEST(LlvmLibcMemcpyTest, CrashOnNullPtr) {
   ASSERT_DEATH([]() { LIBC_NAMESPACE::memcpy(nullptr, nullptr, 1); },
diff --git a/libc/test/src/string/memmove_test.cpp b/libc/test/src/string/memmove_test.cpp
@@ -104,7 +104,7 @@ TEST(LlvmLibcMemmoveTest, SizeSweep) {
     }
 }
 
-#if defined(LIBC_TARGET_OS_IS_LINUX)
+#ifdef LIBC_TARGET_OS_IS_LINUX
 
 TEST(LlvmLibcMemmoveTest, CrashOnNullPtr) {
   ASSERT_DEATH([]() { LIBC_NAMESPACE::memmove(nullptr, nullptr, 0); },
diff --git a/libc/test/src/string/mempcpy_test.cpp b/libc/test/src/string/mempcpy_test.cpp
@@ -27,7 +27,7 @@ TEST(LlvmLibcMempcpyTest, ZeroCount) {
   ASSERT_EQ(static_cast<char *>(result), dest + 0);
 }
 
-#if defined(LIBC_TARGET_OS_IS_LINUX)
+#ifdef LIBC_TARGET_OS_IS_LINUX
 
 TEST(LlvmLibcMempcpyTest, CrashOnNullPtr) {
   ASSERT_DEATH([]() { LIBC_NAMESPACE::mempcpy(nullptr, nullptr, 0); },
diff --git a/libc/test/src/string/memrchr_test.cpp b/libc/test/src/string/memrchr_test.cpp
@@ -114,7 +114,7 @@ TEST(LlvmLibcMemRChrTest, ZeroLengthShouldReturnNullptr) {
   ASSERT_STREQ(call_memrchr(src, 'd', 0), nullptr);
 }
 
-#if defined(LIBC_TARGET_OS_IS_LINUX)
+#ifdef LIBC_TARGET_OS_IS_LINUX
 
 TEST(LlvmLibcMemRChrTest, CrashOnNullPtr) {
   ASSERT_DEATH([]() { LIBC_NAMESPACE::memrchr(nullptr, 'd', 1); },
diff --git a/libc/test/src/string/memset_test.cpp b/libc/test/src/string/memset_test.cpp
@@ -60,7 +60,7 @@ TEST(LlvmLibcMemsetTest, CheckAccess) {
 
 #endif // !defined(LIBC_FULL_BUILD) && defined(LIBC_TARGET_OS_IS_LINUX)
 
-#if defined(LIBC_TARGET_OS_IS_LINUX)
+#ifdef LIBC_TARGET_OS_IS_LINUX
 
 TEST(LlvmLibcMemsetTest, CrashOnNullPtr) {
   ASSERT_DEATH([]() { LIBC_NAMESPACE::memset(nullptr, 0, 1); },
diff --git a/libc/test/src/string/stpncpy_test.cpp b/libc/test/src/string/stpncpy_test.cpp
@@ -73,7 +73,7 @@ TEST_F(LlvmLibcStpncpyTest, CopyTwoWithNull) {
   check_stpncpy(dst, src, 2, expected, 1);
 }
 
-#if defined(LIBC_TARGET_OS_IS_LINUX)
+#ifdef LIBC_TARGET_OS_IS_LINUX
 
 TEST_F(LlvmLibcStpncpyTest, CrashOnNullPtr) {
   ASSERT_DEATH([]() { LIBC_NAMESPACE::stpncpy(nullptr, nullptr, 1); },
diff --git a/libc/test/src/string/strcat_test.cpp b/libc/test/src/string/strcat_test.cpp
@@ -37,7 +37,7 @@ TEST(LlvmLibcStrCatTest, NonEmptyDest) {
   ASSERT_STREQ(dest, "xyzabc");
 }
 
-#if defined(LIBC_TARGET_OS_IS_LINUX)
+#ifdef LIBC_TARGET_OS_IS_LINUX
 
 TEST(LlvmLibcStrCatTest, CrashOnNullPtr) {
   ASSERT_DEATH([]() { LIBC_NAMESPACE::strcat(nullptr, nullptr); },
diff --git a/libc/test/src/string/strcoll_test.cpp b/libc/test/src/string/strcoll_test.cpp
@@ -30,7 +30,7 @@ TEST(LlvmLibcStrcollTest, SimpleTest) {
   ASSERT_GT(result, 0);
 }
 
-#if defined(LIBC_TARGET_OS_IS_LINUX)
+#ifdef LIBC_TARGET_OS_IS_LINUX
 
 TEST(LlvmLibcStrcollTest, CrashOnNullPtr) {
   ASSERT_DEATH([]() { LIBC_NAMESPACE::strcoll(nullptr, nullptr); },
diff --git a/libc/test/src/string/strcpy_test.cpp b/libc/test/src/string/strcpy_test.cpp
@@ -44,7 +44,7 @@ TEST(LlvmLibcStrCpyTest, OffsetDest) {
   ASSERT_STREQ(dest, "xyzabc");
 }
 
-#if defined(LIBC_TARGET_OS_IS_LINUX)
+#ifdef LIBC_TARGET_OS_IS_LINUX
 
 TEST(LlvmLibcStrCpyTest, CrashOnNullPtr) {
   ASSERT_DEATH([]() { LIBC_NAMESPACE::strcpy(nullptr, nullptr); },
diff --git a/libc/test/src/string/strsep_test.cpp b/libc/test/src/string/strsep_test.cpp
@@ -53,7 +53,7 @@ TEST(LlvmLibcStrsepTest, DelimitersShouldNotBeIncludedInToken) {
   }
 }
 
-#if defined(LIBC_TARGET_OS_IS_LINUX)
+#ifdef LIBC_TARGET_OS_IS_LINUX
 
 TEST(LlvmLibcStrsepTest, CrashOnNullPtr) {
   ASSERT_DEATH([]() { LIBC_NAMESPACE::strsep(nullptr, nullptr); },
diff --git a/libc/test/src/string/strspn_test.cpp b/libc/test/src/string/strspn_test.cpp
@@ -85,7 +85,7 @@ TEST(LlvmLibcStrSpnTest, DuplicatedCharactersToBeSearchedForShouldStillMatch) {
   EXPECT_EQ(LIBC_NAMESPACE::strspn("aaaa", "aa"), size_t{4});
 }
 
-#if defined(LIBC_TARGET_OS_IS_LINUX)
+#ifdef LIBC_TARGET_OS_IS_LINUX
 
 TEST(LlvmLibcStrSpnTest, CrashOnNullPtr) {
   ASSERT_DEATH([]() { LIBC_NAMESPACE::strspn(nullptr, nullptr); },

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ TEST(LlvmLibcMemChrTest, SignedCharacterFound) {`
`122`	`122`	`ASSERT_EQ(actual[0], c);`
`123`	`123`	`}`
`124`	`124`
`125`		`-#if defined(LIBC_TARGET_OS_IS_LINUX)`
	`125`	`+#ifdef LIBC_TARGET_OS_IS_LINUX`
`126`	`126`
`127`	`127`	`TEST(LlvmLibcMemChrTest, CrashOnNullPtr) {`
`128`	`128`	`ASSERT_DEATH([]() { LIBC_NAMESPACE::memchr(nullptr, 1, 1); },`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ TEST(LlvmLibcMemcmpTest, SizeSweep) {`
`66`	`66`	`}`
`67`	`67`	`}`
`68`	`68`
`69`		`-#if defined(LIBC_TARGET_OS_IS_LINUX)`
	`69`	`+#ifdef LIBC_TARGET_OS_IS_LINUX`
`70`	`70`
`71`	`71`	`TEST(LlvmLibcMemcmpTest, CrashOnNullPtr) {`
`72`	`72`	`ASSERT_DEATH([]() { LIBC_NAMESPACE::memcmp(nullptr, nullptr, 1); },`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ TEST(LlvmLibcMemmoveTest, SizeSweep) {`
`104`	`104`	`}`
`105`	`105`	`}`
`106`	`106`
`107`		`-#if defined(LIBC_TARGET_OS_IS_LINUX)`
	`107`	`+#ifdef LIBC_TARGET_OS_IS_LINUX`
`108`	`108`
`109`	`109`	`TEST(LlvmLibcMemmoveTest, CrashOnNullPtr) {`
`110`	`110`	`ASSERT_DEATH([]() { LIBC_NAMESPACE::memmove(nullptr, nullptr, 0); },`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ TEST(LlvmLibcMempcpyTest, ZeroCount) {`
`27`	`27`	`ASSERT_EQ(static_cast<char *>(result), dest + 0);`
`28`	`28`	`}`
`29`	`29`
`30`		`-#if defined(LIBC_TARGET_OS_IS_LINUX)`
	`30`	`+#ifdef LIBC_TARGET_OS_IS_LINUX`
`31`	`31`
`32`	`32`	`TEST(LlvmLibcMempcpyTest, CrashOnNullPtr) {`
`33`	`33`	`ASSERT_DEATH([]() { LIBC_NAMESPACE::mempcpy(nullptr, nullptr, 0); },`
Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ TEST(LlvmLibcMemRChrTest, ZeroLengthShouldReturnNullptr) {`
`114`	`114`	`ASSERT_STREQ(call_memrchr(src, 'd', 0), nullptr);`
`115`	`115`	`}`
`116`	`116`
`117`		`-#if defined(LIBC_TARGET_OS_IS_LINUX)`
	`117`	`+#ifdef LIBC_TARGET_OS_IS_LINUX`
`118`	`118`
`119`	`119`	`TEST(LlvmLibcMemRChrTest, CrashOnNullPtr) {`
`120`	`120`	`ASSERT_DEATH([]() { LIBC_NAMESPACE::memrchr(nullptr, 'd', 1); },`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ TEST_F(LlvmLibcStpncpyTest, CopyTwoWithNull) {`
`73`	`73`	`check_stpncpy(dst, src, 2, expected, 1);`
`74`	`74`	`}`
`75`	`75`
`76`		`-#if defined(LIBC_TARGET_OS_IS_LINUX)`
	`76`	`+#ifdef LIBC_TARGET_OS_IS_LINUX`
`77`	`77`
`78`	`78`	`TEST_F(LlvmLibcStpncpyTest, CrashOnNullPtr) {`
`79`	`79`	`ASSERT_DEATH([]() { LIBC_NAMESPACE::stpncpy(nullptr, nullptr, 1); },`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ TEST(LlvmLibcStrCatTest, NonEmptyDest) {`
`37`	`37`	`ASSERT_STREQ(dest, "xyzabc");`
`38`	`38`	`}`
`39`	`39`
`40`		`-#if defined(LIBC_TARGET_OS_IS_LINUX)`
	`40`	`+#ifdef LIBC_TARGET_OS_IS_LINUX`
`41`	`41`
`42`	`42`	`TEST(LlvmLibcStrCatTest, CrashOnNullPtr) {`
`43`	`43`	`ASSERT_DEATH([]() { LIBC_NAMESPACE::strcat(nullptr, nullptr); },`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ TEST(LlvmLibcStrcollTest, SimpleTest) {`
`30`	`30`	`ASSERT_GT(result, 0);`
`31`	`31`	`}`
`32`	`32`
`33`		`-#if defined(LIBC_TARGET_OS_IS_LINUX)`
	`33`	`+#ifdef LIBC_TARGET_OS_IS_LINUX`
`34`	`34`
`35`	`35`	`TEST(LlvmLibcStrcollTest, CrashOnNullPtr) {`
`36`	`36`	`ASSERT_DEATH([]() { LIBC_NAMESPACE::strcoll(nullptr, nullptr); },`