address feedback

Author: cor3ntin

clang/docs/ReleaseNotes.rst

@@ -586,7 +586,7 @@ Bug Fixes to Attribute Support
   ``__attribute__((unused))`` are still ignored after the definition, though
   this behavior may be relaxed in the future). (#GH135481)
 
-- Clang will warn if a completete type specializes a deprecated partial specialization.
+- Clang will warn if a complete type specializes a deprecated partial specialization.
   (#GH44496)
 
 Bug Fixes to C++ Support

clang/include/clang/Sema/Sema.h

@@ -2385,12 +2385,13 @@ class Sema final : public SemaBase {
   /// potential availability violations.
   sema::FunctionScopeInfo *getCurFunctionAvailabilityContext();
 
-  void DiagnoseAvailabilityOfDecl(
-      NamedDecl *D, ArrayRef<SourceLocation> Locs,
-      const ObjCInterfaceDecl *UnknownObjCClass = nullptr,
-      bool ObjCPropertyAccess = false,
-      bool AvoidPartialAvailabilityChecks = false,
-      ObjCInterfaceDecl *ClassReceiver = nullptr);
+  void DiagnoseAvailabilityOfDecl(NamedDecl *D, ArrayRef<SourceLocation> Locs,
+                                  const ObjCInterfaceDecl *UnknownObjCClass,
+                                  bool ObjCPropertyAccess,
+                                  bool AvoidPartialAvailabilityChecks,
+                                  ObjCInterfaceDecl *ClassReceiver);
+
+  void DiagnoseAvailabilityOfDecl(NamedDecl *D, ArrayRef<SourceLocation> Locs);
 
   std::pair<AvailabilityResult, const NamedDecl *>
   ShouldDiagnoseAvailabilityOfDecl(const NamedDecl *D, std::string *Message,

clang/lib/Sema/SemaAvailability.cpp

@@ -1145,3 +1145,11 @@ void Sema::DiagnoseAvailabilityOfDecl(NamedDecl *D,
   EmitAvailabilityWarning(*this, Result, D, OffendingDecl, Message, Locs,
                           UnknownObjCClass, ObjCPDecl, ObjCPropertyAccess);
 }
+
+void Sema::DiagnoseAvailabilityOfDecl(NamedDecl *D,
+                                      ArrayRef<SourceLocation> Locs) {
+  DiagnoseAvailabilityOfDecl(D, Locs, /*UnknownObjCClass=*/nullptr,
+                             /*ObjCPropertyAccess=*/false,
+                             /*AvoidPartialAvailabilityChecks=*/false,
+                             /*ClassReceiver=*/nullptr);
+}

clang/test/CXX/dcl.dcl/dcl.attr/dcl.attr.deprecated/p1.cpp

@@ -75,8 +75,20 @@ template struct B<A>; // expected-note {{requested here}}
 
 
 namespace GH44496 {
-  template <class> struct my_template {
-    using type = void;
+
+
+template <typename T>
+class function { };
+template <typename A>
+class __attribute__((deprecated)) function<void(A)> { };
+// expected-note@-1 {{'function<void (int)>' has been explicitly marked deprecated here}}
+
+void test() {
+    [[maybe_unused]] function<void(int)> f; // expected-warning{{'function<void (int)>' is deprecated}}
+}
+
+template <class> struct my_template {
+  using type = void;
 };
 
 template <class T>