[MLIR][OpenMP]Replaced colon with a comma separator between strict modifier and operand

Author: kaviya2510

mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp

@@ -483,7 +483,7 @@ parseGranularityClause(OpAsmParser &parser, ClauseTypeAttr &prescriptiveness,
   if (succeeded(parser.parseOptionalKeyword(&enumStr))) {
     if (std::optional<ClauseType> enumValue = symbolizeClause(enumStr)) {
       prescriptiveness = ClauseTypeAttr::get(parser.getContext(), *enumValue);
-      if (parser.parseColon())
+      if (parser.parseComma())
         return failure();
     } else {
       return parser.emitError(parser.getCurrentLocation())
@@ -516,7 +516,7 @@ printGranularityClause(OpAsmPrinter &p, Operation *op,
                        StringRef (*stringifyClauseType)(ClauseType)) {
 
   if (prescriptiveness)
-    p << stringifyClauseType(prescriptiveness.getValue()) << ": ";
+    p << stringifyClauseType(prescriptiveness.getValue()) << ", ";
 
   if (operand)
     p << operand << ": " << operandType;

mlir/test/Dialect/OpenMP/invalid.mlir

@@ -2067,7 +2067,7 @@ func.func @taskloop(%lb: i32, %ub: i32, %step: i32) {
 func.func @taskloop(%lb: i32, %ub: i32, %step: i32) {
   %testi64 = "test.i64"() : () -> (i64)
   // expected-error @below {{invalid grainsize modifier : 'strict1'}}
-  omp.taskloop grainsize(strict1: %testi64: i64) {
+  omp.taskloop grainsize(strict1, %testi64: i64) {
     omp.loop_nest (%i, %j) : i32 = (%lb, %ub) to (%ub, %lb) step (%step, %step) {
       omp.yield
     }
@@ -2079,7 +2079,7 @@ func.func @taskloop(%lb: i32, %ub: i32, %step: i32) {
 func.func @taskloop(%lb: i32, %ub: i32, %step: i32) {
   %testi64 = "test.i64"() : () -> (i64)
   // expected-error @below {{invalid num_tasks modifier : 'default'}}
-  omp.taskloop num_tasks(default: %testi64: i64) {
+  omp.taskloop num_tasks(default, %testi64: i64) {
     omp.loop_nest (%i, %j) : i32 = (%lb, %ub) to (%ub, %lb) step (%step, %step) {
       omp.yield
     }

mlir/test/Dialect/OpenMP/ops.mlir

@@ -2417,16 +2417,16 @@ func.func @omp_taskloop(%lb: i32, %ub: i32, %step: i32) -> () {
     }
   }
 
-  // CHECK: omp.taskloop grainsize(strict: %{{[^:]+}}: i64) {
-  omp.taskloop grainsize(strict: %testi64: i64) {
+  // CHECK: omp.taskloop grainsize(strict, %{{[^:]+}}: i64) {
+  omp.taskloop grainsize(strict, %testi64: i64) {
     omp.loop_nest (%i, %j) : i32 = (%lb, %ub) to (%ub, %lb) step (%step, %step) {
       // CHECK: omp.yield
       omp.yield
     }
   }
 
-  // CHECK: omp.taskloop num_tasks(strict: %{{[^:]+}}: i64) {
-  omp.taskloop num_tasks(strict: %testi64: i64) {
+  // CHECK: omp.taskloop num_tasks(strict, %{{[^:]+}}: i64) {
+  omp.taskloop num_tasks(strict, %testi64: i64) {
     omp.loop_nest (%i, %j) : i32 = (%lb, %ub) to (%ub, %lb) step (%step, %step) {
       // CHECK: omp.yield
       omp.yield