accidentally negated a conditional, fixed

alanzhao1 · alanzhao1 · commit 9764b21c8867 · 2025-09-25T15:07:26.000-07:00
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineInternal.h b/llvm/lib/Transforms/InstCombine/InstCombineInternal.h
@@ -475,7 +475,7 @@ class LLVM_LIBRARY_VISIBILITY InstCombinerImpl final
       InsertPosition InsertBefore = nullptr, Instruction *MDFrom = nullptr) {
     SelectInst *SI =
         SelectInst::Create(C, S1, S2, NameStr, InsertBefore, MDFrom);
-    if (!SI) {
+    if (SI && !MDFrom) {
       assert(F && "provided parent function is nullptr!");
       setExplicitlyUnknownBranchWeightsIfProfiled(*SI, *F, DEBUG_TYPE);
     }

Original file line number	Diff line number	Diff line change
`@@ -475,7 +475,7 @@ class LLVM_LIBRARY_VISIBILITY InstCombinerImpl final`
`475`	`475`	`InsertPosition InsertBefore = nullptr, Instruction *MDFrom = nullptr) {`
`476`	`476`	`SelectInst *SI =`
`477`	`477`	`SelectInst::Create(C, S1, S2, NameStr, InsertBefore, MDFrom);`
`478`		`- if (!SI) {`
	`478`	`+ if (SI && !MDFrom) {`
`479`	`479`	`assert(F && "provided parent function is nullptr!");`
`480`	`480`	`setExplicitlyUnknownBranchWeightsIfProfiled(SI, F, DEBUG_TYPE);`
`481`	`481`	`}`