Turns out this check doesn't like templated lambdas

on-behalf-of: @amd <[email protected]>

Author: jjmarr-amd

clang-tools-extra/clang-tidy/readability/AvoidDefaultLambdaCaptureCheck.cpp

@@ -54,6 +54,11 @@ void AvoidDefaultLambdaCaptureCheck::check(
     ImplicitCaptures.push_back(generateCaptureText(Capture));
   }
 
+  // For template-dependent lambdas, the list of captures hasn't been created
+  // yet, so the list of implicit captures is empty.
+  if (ImplicitCaptures.empty() && Lambda->isGenericLambda())
+    return;
+
   const auto ReplacementText = [&ImplicitCaptures]() {
     return llvm::join(ImplicitCaptures, ", ");
   }();

clang-tools-extra/test/clang-tidy/checkers/readability/avoid-default-lambda-capture.cpp

@@ -95,13 +95,13 @@ class TestClass {
   }
 };
 
+// Lambda captures dependent on a template parameter don't have a fix it
 template<typename T>
 void test_template_lambdas() {
   T value{};
 
   auto lambda = [=](T x) { return value + x; };
   // CHECK-MESSAGES: :[[@LINE-1]]:18: warning: lambda default captures are discouraged; prefer to capture specific variables explicitly [readability-avoid-default-lambda-capture]
-  // CHECK-FIXES: auto lambda = [value](T x) { return value + x; };
 }
 
 void instantiate_templates() {