simplify custom print

Author: Jianhui-Li

mlir/include/mlir/Dialect/XeGPU/IR/XeGPUOps.td

@@ -179,17 +179,10 @@ def XeGPU_CreateNdDescOp: XeGPU_Op<"create_nd_tdesc", [Pure, ViewLikeOpInterface
       if (attr) 
         return attr;
 
-      auto memrefType = llvm::dyn_cast<MemRefType>(getSourceType());
-      int rank = 0;
-      if (memrefType) 
-        //use source memref's rank, as source memref rank may be higher
-        rank = memrefType.getRank();
-      else
-        //nd_tdesc created from ui64, use nd_tdesc's rank
-        rank = getMixedSizes().size();
+      int64_t rank = getMixedSizes().size();
 
-      // The offsets are allowed to be empty. The Traits verification of OffsetSizeAndStrideOpInterface interface assumes offsets being present.
-      // place-holder value MAX indicating user doesn't provide offsets, instead of kDynamic which means offsets passed as value.
+      // Set constant offset to MAX to indicate no offsets provided
+      // or else the printer can't differeiate this with valid const_offset value (say 0)
       setConstOffsets(llvm::SmallVector<int64_t, 4>(rank, std::numeric_limits<int64_t>::max()));
 
       attr = getConstOffsetsAttr();

mlir/lib/Dialect/XeGPU/IR/XeGPUOps.cpp

@@ -12,6 +12,7 @@
 #include "mlir/Dialect/XeGPU/IR/XeGPU.h"
 #include "mlir/IR/Builders.h"
 #include "mlir/IR/TypeUtilities.h"
+#include "mlir/Interfaces/ViewLikeInterface.h"
 
 #include "llvm/Support/Debug.h"
 
@@ -328,29 +329,22 @@ ParseResult parseOptionalDynamicIndexList(
   return success();
 }
 
+
 void printOptionalDynamicIndexList(OpAsmPrinter &printer, Operation *op,
                                    OperandRange values,
                                    ArrayRef<int64_t> integers,
-                                   TypeRange valueTypes = TypeRange()) {
+                                   TypeRange valueTypes = TypeRange(),
+                                   AsmParser::Delimiter delimiter = AsmParser::Delimiter::Square){
 
   if (values.empty() && llvm::all_of(integers, [](int64_t i) {
-        // place-holder value MAX indicating user doesn't provide offsets
+        // MAX indiates no user-provided offsets for CreateNdDescOp.
         return i == std::numeric_limits<int64_t>::max();
-      }))
-    return;
-  printer << '[';
-  unsigned dynamicValIdx = 0;
-  llvm::interleaveComma(integers, printer, [&](int64_t integer) {
-    if (ShapedType::isDynamic(integer)) {
-      printer << values[dynamicValIdx];
-      if (!valueTypes.empty())
-        printer << " : " << valueTypes[dynamicValIdx];
-      ++dynamicValIdx;
-    } else {
-      printer << integer;
-    }
-  });
-  printer << ']';
+      }))    
+      return;
+
+  return printDynamicIndexList(printer, op, values, integers,
+                               /*scalableFlags=*/{}, valueTypes, delimiter);
+
 }
 
 //===----------------------------------------------------------------------===//