Skip to content

Commit 97c2d69

Browse files
committed
add review changes.
1 parent 24cf7b3 commit 97c2d69

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

lldb/source/Plugins/Language/CPlusPlus/LibStdcppSpan.cpp

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -81,21 +81,22 @@ class LibStdcppSpanSyntheticFrontEnd : public SyntheticChildrenFrontEnd {
8181

8282
llvm::Expected<size_t> GetIndexOfChildWithName(ConstString name) override {
8383
if (!m_start)
84-
return llvm::createStringError("Type has no child named '%s'",
85-
name.AsCString());
84+
return llvm::createStringError(
85+
llvm::formatv("Type has no child named {0}", name.AsCString()));
86+
8687
auto optional_idx = formatters::ExtractIndexFromString(name.GetCString());
8788
if (!optional_idx) {
88-
return llvm::createStringError("Type has no child named '%s'",
89-
name.AsCString());
89+
return llvm::createStringError(
90+
llvm::formatv("Type has no child named {0}", name.AsCString()));
9091
}
9192
return *optional_idx;
9293
}
9394

9495
private:
95-
ValueObject *m_start = nullptr; /// First element of span. Held, not owned.
96-
CompilerType m_element_type; /// Type of span elements.
97-
size_t m_num_elements = 0; /// Number of elements in span.
98-
uint32_t m_element_size = 0; /// Size in bytes of each span element.
96+
ValueObject *m_start = nullptr; ///< First element of span. Held, not owned.
97+
CompilerType m_element_type; ///< Type of span elements.
98+
size_t m_num_elements = 0; ///< Number of elements in span.
99+
uint32_t m_element_size = 0; ///< Size in bytes of each span element.
99100
};
100101

101102
SyntheticChildrenFrontEnd *

0 commit comments

Comments
 (0)