Skip to content

Commit 97c8a85

Browse files
update comment
1 parent a7ffe1c commit 97c8a85

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

flang/lib/Optimizer/OpenMP/MapsForPrivatizedSymbols.cpp

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -114,11 +114,9 @@ class MapsForPrivatizedSymbolsPass
114114
captureKind = mlir::omp::VariableCaptureKind::ByCopy;
115115
}
116116
}
117-
// TODO: We should be looking at the defaultmap here. However, at this time
118-
// defaultmap on a target directive ins't modelled in the omp MLIR directive
119-
// Once that is in place, we should move both lowering and this pass
120-
// to use a utility function (like getImplicitMapTypeAndKind in
121-
// lib/Lower/OpenMP/OpenMP.cpp) to get the mapFlag value here.
117+
118+
// Use tofrom if what we are mapping is not a trivial type. In all
119+
// likelihood, it is a descriptor
122120
mlir::omp::ClauseMapFlags mapFlag;
123121
if (fir::isa_trivial(fir::unwrapRefType(varType)) ||
124122
fir::isa_char(fir::unwrapRefType(varType)))

0 commit comments

Comments
 (0)