address comemnts

Created using spr 1.3.7

Author: fmayer

clang/lib/Analysis/FlowSensitive/Models/UncheckedStatusOrAccessModel.cpp

@@ -38,18 +38,6 @@ using ::clang::ast_matchers::StatementMatcher;
 
 } // namespace
 
-static void transferStatusOrOkCall(const CXXMemberCallExpr *Expr,
-                                   const MatchFinder::MatchResult &,
-                                   LatticeTransferState &State) {
-  RecordStorageLocation *StatusOrLoc =
-      getImplicitObjectLocation(*Expr, State.Env);
-  if (StatusOrLoc == nullptr)
-    return;
-
-  auto &OkVal = valForOk(locForStatus(*StatusOrLoc), State.Env);
-  State.Env.setValue(*Expr, OkVal);
-}
-
 static bool isStatusOrOperatorBaseType(QualType type) {
   return isRecordTypeWithName(type, "absl::internal_statusor::OperatorBase");
 }
@@ -238,6 +226,18 @@ BoolValue &valForOk(RecordStorageLocation &StatusLoc, Environment &Env) {
   return initializeStatus(StatusLoc, Env);
 }
 
+static void transferStatusOrOkCall(const CXXMemberCallExpr *Expr,
+                                   const MatchFinder::MatchResult &,
+                                   LatticeTransferState &State) {
+  RecordStorageLocation *StatusOrLoc =
+      getImplicitObjectLocation(*Expr, State.Env);
+  if (StatusOrLoc == nullptr)
+    return;
+
+  auto &OkVal = valForOk(locForStatus(*StatusOrLoc), State.Env);
+  State.Env.setValue(*Expr, OkVal);
+}
+
 CFGMatchSwitch<LatticeTransferState>
 buildTransferMatchSwitch(ASTContext &Ctx,
                          CFGMatchSwitchBuilder<LatticeTransferState> Builder) {