[clang][bytecode][NFC] Reject invalid FromTypes in emitBuiltinBitcast

tbaederr · tbaederr · commit 989573d4b677 · 2024-12-02T10:38:16.000+01:00
instead of silently accepting them and failing later.
diff --git a/clang/lib/AST/ByteCode/Compiler.cpp b/clang/lib/AST/ByteCode/Compiler.cpp
@@ -6514,6 +6514,8 @@ bool Compiler<Emitter>::emitBuiltinBitCast(const CastExpr *E) {
       return false;
     if (!this->emitGetPtrLocal(TempOffset, E))
       return false;
+  } else {
+    return false;
   }
 
   if (!ToT || ToT == PT_Ptr) {

Original file line number	Diff line number	Diff line change
`@@ -6514,6 +6514,8 @@ bool Compiler<Emitter>::emitBuiltinBitCast(const CastExpr *E) {`
`6514`	`6514`	`return false;`
`6515`	`6515`	`if (!this->emitGetPtrLocal(TempOffset, E))`
`6516`	`6516`	`return false;`
	`6517`	`+ } else {`
	`6518`	`+ return false;`
`6517`	`6519`	`}`
`6518`	`6520`
`6519`	`6521`	`if (!ToT \|\| ToT == PT_Ptr) {`