Address review comment

preames · preames · commit 989d8b112105 · 2025-09-04T14:04:08.000-07:00
diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -9274,8 +9274,8 @@ SDValue RISCVTargetLowering::lowerSELECT(SDValue Op, SelectionDAG &DAG) const {
 
     // select c, 0, simm12 -> andi (addi c, -1), simm12
     if (isNullConstant(TrueV) && isSimm12Constant(FalseV)) {
-      SDValue Mask = DAG.getNode(ISD::SUB, DL, VT, CondV,
-                                 DAG.getConstant(1, DL, XLenVT));
+      SDValue Mask = DAG.getNode(ISD::ADD, DL, VT, CondV,
+                                 DAG.getSignedConstant(-1, DL, XLenVT));
       return DAG.getNode(ISD::AND, DL, VT, FalseV, Mask);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -9274,8 +9274,8 @@ SDValue RISCVTargetLowering::lowerSELECT(SDValue Op, SelectionDAG &DAG) const {`
`9274`	`9274`
`9275`	`9275`	`// select c, 0, simm12 -> andi (addi c, -1), simm12`
`9276`	`9276`	`if (isNullConstant(TrueV) && isSimm12Constant(FalseV)) {`
`9277`		`- SDValue Mask = DAG.getNode(ISD::SUB, DL, VT, CondV,`
`9278`		`- DAG.getConstant(1, DL, XLenVT));`
	`9277`	`+ SDValue Mask = DAG.getNode(ISD::ADD, DL, VT, CondV,`
	`9278`	`+ DAG.getSignedConstant(-1, DL, XLenVT));`
`9279`	`9279`	`return DAG.getNode(ISD::AND, DL, VT, FalseV, Mask);`
`9280`	`9280`	`}`
`9281`	`9281`