[lldb] Avoid FileSpec indirection where we can use SupportFiles directly

Now that more parts of LLDB know about SupportFiles, avoid going through
FileSpec (and losing the Checksum in the process). Instead, use the
SupportFile directly.

Author: JDevlieghere

lldb/source/Commands/CommandObjectSource.cpp

@@ -1053,7 +1053,7 @@ class CommandObjectSourceList : public CommandObjectParsed {
                   ? sc.line_entry.column
                   : 0;
           target.GetSourceManager().DisplaySourceLinesWithLineNumbers(
-              std::make_shared<SupportFile>(sc.comp_unit->GetPrimaryFile()),
+              sc.comp_unit->GetPrimarySupportFile(),
               sc.line_entry.line, column, lines_to_back_up,
               m_options.num_lines - lines_to_back_up, "->",
               &result.GetOutputStream(), GetBreakpointLocations());
@@ -1174,7 +1174,7 @@ class CommandObjectSourceList : public CommandObjectParsed {
             m_options.num_lines = 10;
           const uint32_t column = 0;
           target.GetSourceManager().DisplaySourceLinesWithLineNumbers(
-              std::make_shared<SupportFile>(sc.comp_unit->GetPrimaryFile()),
+              sc.comp_unit->GetPrimarySupportFile(),
               m_options.start_line, column, 0, m_options.num_lines, "",
               &result.GetOutputStream(), GetBreakpointLocations());
 

lldb/source/Core/SourceManager.cpp

@@ -504,8 +504,7 @@ void SourceManager::File::CommonInitializer(SupportFileSP support_file_sp,
               SymbolContext sc;
               sc_list.GetContextAtIndex(0, sc);
               if (sc.comp_unit)
-                SetSupportFile(std::make_shared<SupportFile>(
-                    sc.comp_unit->GetPrimaryFile()));
+                SetSupportFile(sc.comp_unit->GetPrimarySupportFile());
             }
           }
         }

lldb/source/Symbol/LineTable.cpp

@@ -288,8 +288,8 @@ bool LineTable::ConvertEntryAtIndexToLineEntry(uint32_t idx,
   else
     line_entry.range.SetByteSize(0);
 
-  line_entry.file_sp = std::make_shared<SupportFile>(
-      m_comp_unit->GetSupportFiles().GetFileSpecAtIndex(entry.file_idx));
+  line_entry.file_sp =
+      m_comp_unit->GetSupportFiles().GetSupportFileAtIndex(entry.file_idx);
   line_entry.original_file_sp =
       m_comp_unit->GetSupportFiles().GetSupportFileAtIndex(entry.file_idx);
   line_entry.line = entry.line;