Revert "PR review comment"

vinay-deshmukh · vinay-deshmukh · commit 990228b6f3dd · 2025-08-11T21:24:21.000-04:00
This reverts commit 4fbb472. Fails with: ``` # .---command stderr------------ # | t.tmp.exe: /home/runner/_work/llvm-project/llvm-project/libcxx/test/support/container_test_types.h:399: CopyInsertable<1>::CopyInsertable(const CopyInsertable<Dummy> &) [Dummy = 1]: Assertion `getConstructController()->isInAllocatorConstruct()' failed. # `----------------------------- # error: command failed with exit status: 250 ```
diff --git a/libcxx/include/__tree b/libcxx/include/__tree
@@ -1891,7 +1891,7 @@ __tree<_Tp, _Compare, _Allocator>::__construct_node(_Args&&... __args) {
   } else 
   #endif
   {
-    std::__construct_at(std::addressof(__h->__value_),  std::forward<_Args>(__args)...);
+  __node_traits::construct(__na, std::addressof(__h->__value_), std::forward<_Args>(__args)...);
   }
 
   __h.get_deleter().__value_constructed = true;

Original file line number	Diff line number	Diff line change
`@@ -1891,7 +1891,7 @@ __tree<_Tp, _Compare, _Allocator>::__construct_node(_Args&&... __args) {`
`1891`	`1891`	`} else`
`1892`	`1892`	`#endif`
`1893`	`1893`	`{`
`1894`		`- std::__construct_at(std::addressof(__h->__value_), std::forward<_Args>(__args)...);`
	`1894`	`+ __node_traits::construct(__na, std::addressof(__h->__value_), std::forward<_Args>(__args)...);`
`1895`	`1895`	`}`
`1896`	`1896`
`1897`	`1897`	`__h.get_deleter().__value_constructed = true;`