Reuse loop op lowering, add comment.

Author: jsjodin

flang/include/flang/Parser/parse-tree.h

@@ -5026,6 +5026,7 @@ struct OpenMPLoopConstruct {
   OpenMPLoopConstruct(OmpBeginLoopDirective &&a)
       : t({std::move(a), std::nullopt, std::nullopt, std::nullopt}) {}
   std::tuple<OmpBeginLoopDirective, std::optional<DoConstruct>,
+      // Inner loop construct used to handle tiling for now.
       std::optional<common::Indirection<OpenMPLoopConstruct>>,
       std::optional<OmpEndLoopDirective>>
       t;

flang/lib/Lower/OpenMP/OpenMP.cpp

@@ -2170,42 +2170,6 @@ genLoopOp(lower::AbstractConverter &converter, lower::SymMap &symTable,
   return loopOp;
 }
 
-static mlir::omp::LoopOp genTiledLoopOp(lower::AbstractConverter &converter,
-                                        lower::SymMap &symTable,
-                                        semantics::SemanticsContext &semaCtx,
-                                        lower::pft::Evaluation &eval,
-                                        mlir::Location loc,
-                                        const ConstructQueue &queue,
-                                        ConstructQueue::const_iterator item) {
-  mlir::omp::LoopOperands loopClauseOps;
-  llvm::SmallVector<const semantics::Symbol *> loopReductionSyms;
-  genLoopClauses(converter, semaCtx, item->clauses, loc, loopClauseOps,
-                 loopReductionSyms);
-
-  DataSharingProcessor dsp(converter, semaCtx, item->clauses, eval,
-                           /*shouldCollectPreDeterminedSymbols=*/true,
-                           /*useDelayedPrivatization=*/true, symTable);
-  dsp.processStep1(&loopClauseOps);
-
-  mlir::omp::LoopNestOperands loopNestClauseOps;
-  llvm::SmallVector<const semantics::Symbol *> iv;
-  genLoopNestClauses(converter, semaCtx, eval, item->clauses, loc,
-                     loopNestClauseOps, iv);
-
-  EntryBlockArgs loopArgs;
-  loopArgs.priv.syms = dsp.getDelayedPrivSymbols();
-  loopArgs.priv.vars = loopClauseOps.privateVars;
-  loopArgs.reduction.syms = loopReductionSyms;
-  loopArgs.reduction.vars = loopClauseOps.reductionVars;
-
-  auto loopOp =
-      genWrapperOp<mlir::omp::LoopOp>(converter, loc, loopClauseOps, loopArgs);
-  genLoopNestOp(converter, symTable, semaCtx, eval, loc, queue, item,
-                loopNestClauseOps, iv, {{loopOp, loopArgs}},
-                llvm::omp::Directive::OMPD_loop, dsp);
-  return loopOp;
-}
-
 static mlir::omp::MaskedOp
 genMaskedOp(lower::AbstractConverter &converter, lower::SymMap &symTable,
             lower::StatementContext &stmtCtx,
@@ -3686,7 +3650,7 @@ static void genOMPDispatch(lower::AbstractConverter &converter,
     break;
   case llvm::omp::Directive::OMPD_tile:
     newOp =
-        genTiledLoopOp(converter, symTable, semaCtx, eval, loc, queue, item);
+        genLoopOp(converter, symTable, semaCtx, eval, loc, queue, item);
     break;
   case llvm::omp::Directive::OMPD_unroll: {
     unsigned version = semaCtx.langOptions().OpenMPVersion;