Skip to content

Commit 99b6785

Browse files
committed
fix typos in comments
1 parent e3c5c56 commit 99b6785

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

mlir/lib/Dialect/Vector/Transforms/VectorEmulateNarrowType.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1256,28 +1256,28 @@ static Value rewriteI2ToI8SignedExt(PatternRewriter &rewriter, Location loc,
12561256
auto i8VecType = VectorType::get(i8VecShape, rewriter.getI8Type());
12571257
Value i8Vector = rewriter.create<vector::BitCastOp>(loc, i8VecType, srcValue);
12581258

1259-
// Position 0 (bits 0-1)
1259+
// Element 0 (bits 0-1)
12601260
constexpr int8_t shiftConst6 = 6;
12611261
auto shiftAttr6 = DenseElementsAttr::get(i8VecType, shiftConst6);
12621262
auto shiftValues6 = rewriter.create<arith::ConstantOp>(loc, shiftAttr6);
12631263
Value shl0 = rewriter.create<arith::ShLIOp>(loc, i8Vector, shiftValues6);
12641264
Value elem0 = rewriter.create<arith::ShRSIOp>(loc, shl0, shiftValues6);
12651265

1266-
// Position 1 (bits 2-3)
1266+
// Element 1 (bits 2-3)
12671267
constexpr int8_t shiftConst4 = 4;
12681268
auto shiftAttr4 = DenseElementsAttr::get(i8VecType, shiftConst4);
12691269
auto shiftValues4 = rewriter.create<arith::ConstantOp>(loc, shiftAttr4);
12701270
Value shl1 = rewriter.create<arith::ShLIOp>(loc, i8Vector, shiftValues4);
12711271
Value elem1 = rewriter.create<arith::ShRSIOp>(loc, shl1, shiftValues6);
12721272

1273-
// Position 1 (bits 4-5)
1273+
// Element 2 (bits 4-5)
12741274
constexpr int8_t shiftConst2 = 2;
12751275
auto shiftAttr2 = DenseElementsAttr::get(i8VecType, shiftConst2);
12761276
auto shiftValues2 = rewriter.create<arith::ConstantOp>(loc, shiftAttr2);
12771277
Value shl2 = rewriter.create<arith::ShLIOp>(loc, i8Vector, shiftValues2);
12781278
Value elem2 = rewriter.create<arith::ShRSIOp>(loc, shl2, shiftValues6);
12791279

1280-
// Position 3 (bits 6-7)
1280+
// Element 3 (bits 6-7)
12811281
Value elem3 = rewriter.create<arith::ShRSIOp>(loc, i8Vector, shiftValues6);
12821282

12831283
// interleave all 4 elements by first interleaving even elements and then odd

0 commit comments

Comments
 (0)