Fix importer tail kind conversion

Author: bcardosolopes

mlir/lib/Target/LLVMIR/ModuleImport.cpp

@@ -2195,15 +2195,18 @@ LogicalResult ModuleImport::convertInstruction(llvm::Instruction *inst) {
         if (!resultTy)
           return failure();
         ArrayAttr operandAttrs = convertAsmInlineOperandAttrs(*callInst);
+        bool hasTailCallKind =
+            callInst->getTailCallKind() != llvm::CallInst::TCK_None;
         return builder
             .create<InlineAsmOp>(
                 loc, resultTy, *operands,
                 builder.getStringAttr(asmI->getAsmString()),
                 builder.getStringAttr(asmI->getConstraintString()),
                 asmI->hasSideEffects(), asmI->isAlignStack(),
-                callInst->isTailCall()
+                hasTailCallKind
                     ? TailCallKindAttr::get(mlirModule.getContext(),
-                                            TailCallKind::Tail)
+                                            convertTailCallKindFromLLVM(
+                                                callInst->getTailCallKind()))
                     : nullptr,
                 AsmDialectAttr::get(
                     mlirModule.getContext(),

mlir/test/Target/LLVMIR/Import/instructions.ll

@@ -556,6 +556,9 @@ define void @inlineasm2() {
   ; CHECK: {{.*}} = llvm.alloca %0 x !llvm.ptr {alignment = 8 : i64} : (i32) -> !llvm.ptr
   ; CHECK-NEXT: llvm.inline_asm has_side_effects tail_call_kind = <tail> asm_dialect = att operand_attrs = [{elementtype = !llvm.ptr}] "", "*m,~{memory}" {{.*}} : (!llvm.ptr) -> !llvm.void
   tail call void asm sideeffect "", "*m,~{memory}"(ptr elementtype(ptr) %p)
+
+  ; CHECK: llvm.inline_asm has_side_effects tail_call_kind = <notail> asm_dialect = att operand_attrs = [{elementtype = !llvm.ptr}] "", "*m,~{memory}" {{.*}} : (!llvm.ptr) -> !llvm.void
+  notail call void asm sideeffect "", "*m,~{memory}"(ptr elementtype(ptr) %p)
   ret void
 }