Skip to content

Commit 9b8b43d

Browse files
committed
Address code review.
1 parent cfdc210 commit 9b8b43d

File tree

4 files changed

+0
-22
lines changed

4 files changed

+0
-22
lines changed

llvm/lib/Target/SPIRV/SPIRVAsmPrinter.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,6 @@ void SPIRVAsmPrinter::outputExecutionModeFromMDNode(
459459
unsigned ExpectMDOps, int64_t DefVal) {
460460
MCInst Inst;
461461
Inst.setOpcode(SPIRV::OpExecutionMode);
462-
463462
Inst.addOperand(MCOperand::createReg(Reg));
464463
Inst.addOperand(MCOperand::createImm(static_cast<unsigned>(EM)));
465464
addOpsFromMDNode(Node, Inst, MAI);

llvm/test/CodeGen/SPIRV/extensions/SPV_KHR_float_controls2/decoration.ll

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,6 @@ entry:
8787
ret void
8888
}
8989

90-
!llvm.module.flags = !{!12}
91-
!llvm.ident = !{!13}
92-
!spirv.EntryPoint = !{}
93-
9490
!3 = !{!5, !4}
9591
!4 = !{i32 42} ; 42 is NoContraction decoration
9692
!5 = !{i32 40, i32 393216} ; 40 is FPFastMathMode
97-
!12 = !{i32 1, !"wchar_size", i32 4}
98-
!13 = !{!"clang version 8.0.1"}

llvm/test/CodeGen/SPIRV/extensions/SPV_KHR_float_controls2/exec_mode.ll

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,8 @@ entry:
3434
ret void
3535
}
3636

37-
!llvm.module.flags = !{!12}
38-
!llvm.ident = !{!13}
39-
!spirv.EntryPoint = !{}
4037
!spirv.ExecutionMode = !{!17, !18, !19, !20, !21, !22, !23, !24, !25, !26}
4138

42-
4339
; CHECK: OpEntryPoint Kernel %[[#KERNEL_HALF:]] "k_float_controls_half"
4440
!0 = !{ptr @k_float_controls_half, !"k_float_controls_half", !6, i32 0, !6, !7, !8, i32 0, i32 0}
4541

@@ -60,9 +56,6 @@ entry:
6056
!6 = !{i32 2, i32 2}
6157
!7 = !{i32 32, i32 36}
6258
!8 = !{i32 0, i32 0}
63-
!12 = !{i32 1, !"wchar_size", i32 4}
64-
!13 = !{!"clang version 8.0.1"}
65-
!14 = !{i32 1, i32 0}
6659

6760
; CHECK-DAG: OpExecutionMode %[[#KERNEL_HALF]] FPFastMathDefault %[[#HALF_TYPE:]] 1
6861
!17 = !{ptr @k_float_controls_half, i32 6028, half poison, i32 1}

llvm/test/CodeGen/SPIRV/extensions/SPV_KHR_float_controls2/exec_mode2.ll

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,8 @@ entry:
1414
ret void
1515
}
1616

17-
18-
!llvm.module.flags = !{!12}
19-
!llvm.ident = !{!13}
20-
!spirv.EntryPoint = !{}
2117
!spirv.ExecutionMode = !{!19, !20, !21, !22, !23, !24, !25, !26, !27}
2218

23-
2419
; CHECK: OpEntryPoint Kernel %[[#KERNEL_FLOAT:]] "k_float_controls_float"
2520
!2 = !{ptr @k_float_controls_float, !"k_float_controls_float", !6, i32 0, !6, !7, !8, i32 0, i32 0}
2621
; CHECK: OpEntryPoint Kernel %[[#KERNEL_ALL:]] "k_float_controls_all"
@@ -29,9 +24,6 @@ entry:
2924
!6 = !{i32 2, i32 2}
3025
!7 = !{i32 32, i32 36}
3126
!8 = !{i32 0, i32 0}
32-
!12 = !{i32 1, !"wchar_size", i32 4}
33-
!13 = !{!"clang version 8.0.1"}
34-
!14 = !{i32 1, i32 0}
3527

3628
; CHECK-DAG: OpExecutionMode %[[#KERNEL_FLOAT]] FPFastMathDefault %[[#FLOAT_TYPE:]] 131079
3729
!19 = !{ptr @k_float_controls_float, i32 6028, float poison, i32 131079}

0 commit comments

Comments
 (0)