Linting

Author: higher-performance

clang/lib/AST/DeclCXX.cpp

@@ -1118,9 +1118,8 @@ void CXXRecordDecl::addedMember(Decl *D) {
     } else if (!T.isCXX98PODType(Context))
       data().PlainOldData = false;
 
-    if (Field->hasAttr<ExplicitInitAttr>() && !Field->hasInClassInitializer()) {
+    if (Field->hasAttr<ExplicitInitAttr>() && !Field->hasInClassInitializer())
       setHasUninitializedExplicitInitFields(true);
-    }
 
     if (T->isReferenceType()) {
       if (!Field->hasInClassInitializer())
@@ -2202,26 +2201,24 @@ void CXXRecordDecl::completeDefinition(CXXFinalOverriderMap *FinalOverriders) {
   if (isAggregate() && hasUserDeclaredConstructor() &&
       !Context.getLangOpts().CPlusPlus20) {
     // Diagnose any aggregate behavior changes in C++20
-    for (field_iterator I = field_begin(), E = field_end(); I != E; ++I) {
-      if (const auto *attr = I->getAttr<ExplicitInitAttr>()) {
+    for (const FieldDecl *FD : RD->fields()) {
+      if (const auto *AT = FD->getAttr<ExplicitInitAttr>())
         Context.getDiagnostics().Report(
-            attr->getLocation(),
+            AT->getLocation(),
             diag::warn_cxx20_compat_requires_explicit_init_non_aggregate)
-            << attr << Context.getRecordType(this);
-      }
+            << AT << Context.getRecordType(this);
     }
   }
 
   if (!isAggregate() && hasUninitializedExplicitInitFields()) {
     // Diagnose any fields that required explicit initialization in a
     // non-aggregate type. (Note that the fields may not be directly in this
     // type, but in a subobject. In such cases we don't emit diagnoses here.)
-    for (field_iterator I = field_begin(), E = field_end(); I != E; ++I) {
-      if (const auto *attr = I->getAttr<ExplicitInitAttr>()) {
-        Context.getDiagnostics().Report(attr->getLocation(),
+    for (const FieldDecl *FD : RD->fields()) {
+      if (const auto *AT = FD->getAttr<ExplicitInitAttr>())
+        Context.getDiagnostics().Report(AT->getLocation(),
                                         diag::warn_attribute_needs_aggregate)
-            << attr << Context.getRecordType(this);
-      }
+            << AT << Context.getRecordType(this);
     }
     setHasUninitializedExplicitInitFields(false);
   }

clang/lib/Sema/SemaDecl.cpp

@@ -19189,9 +19189,8 @@ void Sema::ActOnFields(Scope *S, SourceLocation RecLoc, Decl *EnclosingDecl,
         if (FT.hasNonTrivialToPrimitiveCopyCUnion() || Record->isUnion())
           Record->setHasNonTrivialToPrimitiveCopyCUnion(true);
       }
-      if (FD->hasAttr<ExplicitInitAttr>()) {
+      if (FD->hasAttr<ExplicitInitAttr>())
         Record->setHasUninitializedExplicitInitFields(true);
-      }
       if (FT.isDestructedType()) {
         Record->setNonTrivialToPrimitiveDestroy(true);
         Record->setParamDestroyedInCallee(true);

clang/lib/Sema/SemaInit.cpp

@@ -266,9 +266,8 @@ static void CheckStringInit(Expr *Str, QualType &DeclT, const ArrayType *AT,
 
 void emitUninitializedExplicitInitFields(Sema &S, const RecordDecl *R) {
   for (const FieldDecl *Field : R->fields()) {
-    if (Field->hasAttr<ExplicitInitAttr>()) {
+    if (Field->hasAttr<ExplicitInitAttr>())
       S.Diag(Field->getLocation(), diag::note_entity_declared_at) << Field;
-    }
   }
 }