Fix valid FC values for unsigned AMO load builtins

Author: maryammo

clang/lib/Sema/SemaPPC.cpp

@@ -261,11 +261,12 @@ bool SemaPPC::CheckPPCBuiltinFunctionCall(const TargetInfo &TI,
     if (SemaRef.BuiltinConstantArg(TheCall, 2, Result))
       return true;
     unsigned Val = Result.getZExtValue();
-    if ((Val <= 8) || Val == 16 || (Val >= 24 && Val <= 25) || Val == 28)
+    static constexpr unsigned ValidFC[] = {0, 1, 2, 3, 4, 6, 8, 16, 24, 25, 28};
+    if (llvm::is_contained(ValidFC, Val))
       return false;
     Expr *Arg = TheCall->getArg(2);
     return SemaRef.Diag(Arg->getBeginLoc(), diag::err_argument_invalid_range)
-           << toString(Result, 10) << "0-8, 16, 24-25" << "28"
+           << toString(Result, 10) << "0-4, 6, 8, 16, 24-25" << "28"
            << Arg->getSourceRange();
   }
   }

clang/test/CodeGen/PowerPC/builtins-amo-err.c

@@ -7,12 +7,12 @@ void test_amo() {
   unsigned int *ptr1, value1;
   // AIX32-ERROR: error: this builtin is only available on 64-bit targets
   __builtin_amo_lwat(ptr1, value1, 0);
-  // FC-ERROR: argument value 9 is outside the valid range [0-8, 16, 24-25, 28]
+  // FC-ERROR: argument value 9 is outside the valid range [0-4, 6, 8, 16, 24-25, 28]
   __builtin_amo_lwat(ptr1, value1, 9);
 
   unsigned long int *ptr2, value2;
   // AIX32-ERROR: error: this builtin is only available on 64-bit targets
   __builtin_amo_ldat(ptr2, value2, 3);
-  // FC-ERROR: error: argument value 26 is outside the valid range [0-8, 16, 24-25, 28]
+  // FC-ERROR: error: argument value 26 is outside the valid range [0-4, 6, 8, 16, 24-25, 28]
   __builtin_amo_ldat(ptr2, value2, 26);
 }